was Moderators should not see emails in SSO section - #13 by techAPJ reverted? It seems moderators are able to see the payload (which contains the email) again.

Not sure, @techAPJ can you have a peek when you are back?

I am not able to repro this on latest Discourse version. [תמונה] anon60302432: It seems moderators are able to see the payload (which contains the email) again. Note that moderators will see the SSO payload but that payload will not contain external_email.

Is it possible to restrict visibility of the entire SSO section for mods?

Just updated to beta 3 and ran a test. Account only had moderator, last payload included the email even with the “moderators can see emails” option disabled. email= external_id= name= nonce= username= I noticed you mentioned external_email but on our payload its “email”, not “external_email”, m…

[תמונה] anon60302432: last payload included the email even with the “moderators can see emails” option disabled. Are you talking about the /admin/users/{id}/{username} page or somewhere else?

[תמונה] anon60302432: I noticed you mentioned external_email but on our payload its “email”, not “external_email”, maybe that’s why? Is that something we need to fix on our end? No, when the SSO record is created the external_email is saved as per: app/models/discourse_single_sign_on…

Aha, I see that the payload is visible to moderators. I’ve hidden the SSO payload for moderators via: https://github.com/discourse/discourse/commit/901d6080df6a62c8fbb4da697a9150fdd93211da We’re also discussing if the payload should be behind a button click for Admins (like we do for emails). Tha…

טוען SSO יכול להיראות שוב על ידי מנהלים?

תמיכה

anon60302432 8 בפברואר,‏ 2021,‏ 8:03pm 6

To add on, I believe I used this post when creating our SSO process: Discourse SSO and API Helper for PHP. Uses “email” as one of the parameters, not “external_email”

@techAPJ

נושא		תגובות	צפיות
User email is not hidden under Single Sign On area of admin page Bug	3	655	17 בפברואר,‏ 2021
Moderators should not see emails in SSO section UX	11	1722	11 בנובמבר,‏ 2020
Can no longer view users emails as a moderator Support	5	1215	28 ביוני,‏ 2018
DiscourseConnect Single Sign On email & last payload cached across users Bug	1	779	20 באוקטובר,‏ 2021
SSO is forcibly creating the user as an admin Bug	12	1219	16 בספטמבר,‏ 2021

טוען SSO יכול להיראות שוב על ידי מנהלים?

נושאים קשורים