was Moderators should not see emails in SSO section - #13 by techAPJ reverted? It seems moderators are able to see the payload (which contains the email) again.

Not sure, @techAPJ can you have a peek when you are back?

I am not able to repro this on latest Discourse version. [图片] anon60302432: It seems moderators are able to see the payload (which contains the email) again. Note that moderators will see the SSO payload but that payload will not contain external_email.

Is it possible to restrict visibility of the entire SSO section for mods?

Just updated to beta 3 and ran a test. Account only had moderator, last payload included the email even with the “moderators can see emails” option disabled. email= external_id= name= nonce= username= I noticed you mentioned external_email but on our payload its “email”, not “external_email”, maybe that’s why? Is that something we need to fix on our end?

To add on, I believe I used this post when creating our SSO process: Discourse SSO and API Helper for PHP. Uses “email” as one of the parameters, not “external_email” @techAPJ

[图片] anon60302432: last payload included the email even with the “moderators can see emails” option disabled. Are you talking about the /admin/users/{id}/{username} page or somewhere else?

[图片] anon60302432: I noticed you mentioned external_email but on our payload its “email”, not “external_email”, maybe that’s why? Is that something we need to fix on our end? No, when the SSO record is created the external_email is saved as per: app/models/discourse_single_sign_on.rb 821bb1e8c user.create_single_sign_on_record!( last_payload: unsigned_payload, external_id: external_id, external_username: username, external_email: email, external_name: name, external_avatar_url: avatar_url, external_profile_background_url: profile_background_url, external_card_background_url: card_background_url ) In reference to: email= external_id= name= nonce= username= Where are you seeing this payload in Discourse? As you can see above the email is saved as external_email, name is saved as external_name, etc.

Aha, I see that the payload is visible to moderators. I’ve hidden the SSO payload for moderators via: https://github.com/discourse/discourse/commit/901d6080df6a62c8fbb4da697a9150fdd93211da We’re also discussing if the payload should be behind a button click for Admins (like we do for emails). Thanks for the excellent report @anon60302432, and for persistent follow-up. :trophy:

SSO载荷可以再次被版主看到了吗？

产品支持

anon60302432 2021 年2 月 8 日 20:03 6

补充一点，我认为在创建我们的 SSO 流程时使用了此帖子：Discourse SSO and API Helper for PHP

@techAPJ

话题		回复	浏览量
User email is not hidden under Single Sign On area of admin page Bug	3	773	2021 年2 月 17 日
Moderators should not see emails in SSO section UX	11	1897	2020 年11 月 11 日
Can no longer view users emails as a moderator Product Support	5	1307	2018 年6 月 28 日
DiscourseConnect Single Sign On email & last payload cached across users Bug	1	812	2021 年10 月 20 日
SSO is forcibly creating the user as an admin Bug	12	1456	2021 年9 月 16 日

SSO载荷可以再次被版主看到了吗？

相关话题