# Stable is well... broken

**URL:** https://meta.discourse.org/t/stable-is-well-broken/84396
**Category:** Support
**Created:** [April 2, 2018, 5:59pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396 "2018-04-02T17:59:24Z")
**Posts on this page:** 9
**Page:** 1

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [April 2, 2018, 5:59pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/1 "2018-04-02T17:59:24Z")

</div>

Hey guys,

We were just deploying a few new servers and my conclusion is that the stable branch is lacking a few backports of crucial bug fixes. I don’t have a lot of experience with cherry picking but I can point out the issues in question.

It’s the [orientation](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/6) fix and the [backup restore](https://meta.discourse.org/t/changes-introduced-in-postgresql-9-5-12-and-10-3-cause-backup-related-failures/82555/3) fix.

Any chance of getting those back into the stable branch soon? Anything we can do to help here?

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [April 3, 2018, 4:37am UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/2 "2018-04-03T04:37:47Z")

</div>

Not sure maybe @tgxworld can see what he thinks.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [April 4, 2018, 8:58am UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/3 "2018-04-04T08:58:41Z")

</div>

The fixes for restoring backups taken with the new `pg_dump` clients have been back-ported into stable.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [April 4, 2018, 9:05am UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/5 "2018-04-04T09:05:01Z")

</div>

A post was merged into an existing topic: [Help .. rebuild app failed](https://meta.discourse.org/t/help-rebuild-app-failed/84538)

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [April 4, 2018, 6:01pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/6 "2018-04-04T18:01:53Z")

</div>

Thanks for backporting these fixes!

However, it does not work. I have been testing this and restoring the backup is still failing.  
I was able to nail it down to this migration that was not backported but which is crucial:

> <https://github.com/discourse/discourse/blob/10d6101eae2f613f8489754144feaff2324727c5/db/migrate/20180308071922_drop_raise_read_only_function.rb>

EDIT I have just double checked and when I add this migration, backup/restore is functioning correctly again.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [April 4, 2018, 11:23pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/7 "2018-04-04T23:23:58Z")

</div>

Backported as well, thanks for digging into this 👍

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [April 5, 2018, 5:50pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/8 "2018-04-05T17:50:52Z")

</div>

And here is the final confirmation that backup/restores are working correctly on stable again!

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [April 5, 2018, 9:05pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/9 "2018-04-05T21:05:26Z")

</div>

Thank you for helping us work through this 🙏

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [April 5, 2018, 9:05pm UTC](https://meta.discourse.org/t/stable-is-well-broken/84396/10 "2018-04-05T21:05:32Z")

</div>


