Stop appending ?username to url when badge system disabled?

Johani · September 28, 2020, 4:14pm

We will now stop appending the username parameter to share URLs when badges are disabled

DEV: don't add username to share links when badges are disabled (#10730)

committed 04:12PM - 28 Sep 20 UTC

Context: https://meta.discourse.org/t/stop-appending-username-to-url-when-badge-…system-disabled/164904 Share links for topics and posts have the current username appended to them when the user is logged in. If badges are disabled, those added usernames are not beneficial since they're only used to track progress towards certain badges. This PR makes two change. 1. it moves the logic for the share link url to a centralized helper because it's shared in both topic and post models. 2. it stops username params from being added to share links when badges are disabled.

Topic		Replies	Views
Disable “?u=<user>” in shared links Support	12	2486	October 11, 2018
When sharing a topic Support	6	734	March 3, 2019
Per-user opt-in of appending the username on link sharing Feature	21	1875	February 24, 2023
"Share a link" for a post should not leak username Feature completed	27	5000	September 29, 2022
Reason for link share username appending at the end Support	4	460	May 28, 2023

Stop appending ?username to url when badge system disabled?

Related topics