Submitting preferences form with "enter" submits the form natively

Bug
8

It is 100% reproducable in a clean dv environment.

On Chrome latest:

dv new enter-submit
http://enter-submit.localhost/session/user1/become
visit
http://enter-submit.localhost/u/user1/preferences/account
change name
click enter

Page reloads.

How are we feeling about something like this @martin / @j.jaffeux in /frontend/discourse/app/controllers/preferences.js:

      
    @action
    preventSubmit(event) {
       event?.preventDefault();
    }
    <form class="form-vertical" {{on "submit" this.preventSubmit}}>
       {{outlet}}
     </form>
   </section>

It is a bit odd that we have a form that is not really a form in this very specific case.

2 Likes