# הצעה: הפעלת כלל \`eol-last\` עבור eslint ו-ember-template-lint
**URL:** https://meta.discourse.org/t/suggestion-enable-eol-last-rule-for-eslint-and-ember-template-lint/186471
**Category:** Development
**Created:** [12 באפריל, 2021, 8:46am UTC](https://meta.discourse.org/t/suggestion-enable-eol-last-rule-for-eslint-and-ember-template-lint/186471 "2021-04-12T08:46:13Z")
**Posts on this page:** 3
**Page:** 1
### Author:  [@fzngagan](https://meta.discourse.org/u/fzngagan)
#### Post date: [12 באפריל, 2021, 8:46am UTC](https://meta.discourse.org/t/suggestion-enable-eol-last-rule-for-eslint-and-ember-template-lint/186471/1 "2021-04-12T08:46:13Z")
Its a general dev practice to add a newline at the end of the file as github always complains about it. My suggestion is to enable the `eol-last` rule for eslint and `ember-template-lint`. I see this code here which has it under a comment.
>
Thoughts @riking ?
---
### Author:  [@riking](https://meta.discourse.org/u/riking)
#### Post date: [12 באפריל, 2021, 5:27pm UTC](https://meta.discourse.org/t/suggestion-enable-eol-last-rule-for-eslint-and-ember-template-lint/186471/2 "2021-04-12T17:27:20Z")
Oops, I forgot about that one!
I put rules that had too many violations / diffs as “pending” while working on that file. So the way to see the explanation is to enable it and see what gets changed.
---
### Author:  [@fzngagan](https://meta.discourse.org/u/fzngagan)
#### Post date: [12 באפריל, 2021, 6:45pm UTC](https://meta.discourse.org/t/suggestion-enable-eol-last-rule-for-eslint-and-ember-template-lint/186471/3 "2021-04-12T18:45:36Z")
There were only a handlful of errors, so I ended up fixing them and making a PR.
Also, Am I correct in thinking that the CI used the updated config to run the checks?
[https://github.com/discourse/discourse/pull/12678](https://github.com/discourse/discourse/pull/12678)