# Support for full\_screen\_login feature like saml plugin

**URL:** https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609
**Category:** SSO
**Tags:** oauth2
**Created:** [2017年七月28日 13:14 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609 "2017-07-28T13:14:22Z")
**Posts on this page:** 6
**Page:** 1

<div class="post-metadata">

### Author: ![trobiyo](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/trobiyo/32/311872_2.png) [@trobiyo](https://meta.discourse.org/u/trobiyo)
#### Post date: [2017年七月28日 13:14 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/1 "2017-07-28T13:14:22Z")

</div>

@eviltrout, any plans to add **full\_screen\_login** feature like saml plugin ([discourse-saml/plugin.rb at main · discourse/discourse-saml · GitHub](https://github.com/discourse/discourse-saml/blob/master/plugin.rb))?

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [2017年七月28日 14:31 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/2 "2017-07-28T14:31:29Z")

</div>

It’s not on my list in the foreseeable future. Maybe someone from the community can help out here.

---

<div class="post-metadata">

### Author: ![Nick\_Shearer\_nsheare](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nick_shearer_nsheare/32/119547_2.png) [@Nick\_Shearer\_nsheare](https://meta.discourse.org/u/Nick_Shearer_nsheare)
#### Post date: [2018年七月26日 00:49 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/3 "2018-07-26T00:49:44Z")

</div>

I made a couple of PRs that would support this. Seems like it’s not possible to do it exclusively from the plugin side (unless all oauth2-basic plugins were full screen).

PRs are up at:

[https://github.com/discourse/discourse/pull/6180](https://github.com/discourse/discourse/pull/6180)  
[https://github.com/discourse/discourse-oauth2-basic/pull/14](https://github.com/discourse/discourse-oauth2-basic/pull/14)

in case anyone wants to have a look at em.

Maybe there is a cleaner way but it wasn’t apparent to me.

Would resolve some UX issues around the popup window for those of us exclusively using an OAuth2 login.

Cheers,

Nick

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年七月27日 10:21 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/7 "2018-07-27T10:21:34Z")

</div>

Those PRs are now both merged. Thanks for the contributions @Nick_Shearer_nsheare 😃

---

<div class="post-metadata">

### Author: ![Nick\_Shearer\_nsheare](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nick_shearer_nsheare/32/119547_2.png) [@Nick\_Shearer\_nsheare](https://meta.discourse.org/u/Nick_Shearer_nsheare)
#### Post date: [2018年七月27日 14:54 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/8 "2018-07-27T14:54:46Z")

</div>

thanks for the help! 🙂

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [2018年七月30日 17:00 UTC](https://meta.discourse.org/t/support-for-full-screen-login-feature-like-saml-plugin/90609/9 "2018-07-30T17:00:08Z")

</div>

This topic was automatically closed after 3 days. New replies are no longer allowed.
