System notification when posting remote images


(Adnan) #1

Hey,

I’m getting a system notification every time I post a comment or topic. My account is set as admin, discourse is on latest version and data was imported from vanilla forum.

I have another instance of discourse running on a different droplet, issue doesn’t occur there and it was not a vanilla import.


(Jeff Atwood) #2

Looks like you are posting remote hotlinked images (e.g. http://example.com/img.png), and the system is downloading them to local and editing your post to change the local image path.

Either upload the images, or disable remote image downloading.


(Jens Maier) #3

I was going to suggest to instead enable the disable edit notifications site setting, but after a quick glance at the code it appears that this setting disables more than its description suggests.

According to the description, it suppresses edit notifications generated by system edits due to image downloading; in the code, it completely short-circuits PostAlertObserver#after_create_post_revision, regardless of which user created the revision or why.

Is that really the intended behaviour?


(Adnan) #4

That makes sense, I didn’t realize it was an intended notification. Thanks for the clarification.


(Jeff Atwood) #5

Probably worth a look when you are back, @zogstrip.


(Régis Hanol) #6

That is now fixed :panda_face:

https://github.com/discourse/discourse/commit/598a3f3e1079d072483f0b34dff5fe6f8d67a45a


(Kane York) #7

Is the description of the setting correct?


(Jeff Atwood) #8

Good point I updated the site setting copy.


(Jeff Atwood) #9