# Text glitch on group admin page

**URL:** https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
**Category:** Bug
**Created:** [January 5, 2018, 11:18am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303 "2018-01-05T11:18:09Z")
**Posts on this page:** 10
**Page:** 1

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [January 5, 2018, 11:18am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/1 "2018-01-05T11:18:09Z")

</div>

Update: [PR pending]

When logged in as admin, I see “enter username” on the group editor, but when logged in as a non-admin member, I see “[en.admin.groups.selector\_placeholder]”:

 ![15](https://global.discourse-cdn.com/meta/original/3X/a/1/a14b933541ef095629a32c51b27fa01a5ecd9efc.png)

I’ll see if I can create a PR to fix this - I’m assuming that customised text with “admin.” prefix is not available to non-admin clients.

---

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [January 5, 2018, 12:08pm UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/2 "2018-01-05T12:08:01Z")

</div>

I have created a PR with a fix:

[https://github.com/discourse/discourse/pull/5473](https://github.com/discourse/discourse/pull/5473)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [January 8, 2018, 1:53am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/3 "2018-01-08T01:53:24Z")

</div>

One odd thing here @eviltrout is that we have admin client localization file but do not have moderator client localization file. Would make sense either to centralize so we have “staff” client/server locale files, or split so there is both admin and moderator stuff.

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [January 8, 2018, 2:51pm UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/4 "2018-01-08T14:51:06Z")

</div>

I’ve always thought of the admin locale as “admin section” so it should apply to moderators too. I’m happy to rename it to staff if that makes it more clear. Either way if you are on an `/admin` path it should be loaded.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [January 8, 2018, 8:39pm UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/5 "2018-01-08T20:39:13Z")

</div>

Hmm 🤔 so how is this bug possible?

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [January 8, 2018, 8:55pm UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/6 "2018-01-08T20:55:45Z")

</div>

It _should_ be loaded but perhaps it is currently not.

---

<div class="post-metadata">

### Author: ![Mittineague](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mittineague/32/114259_2.png) [@Mittineague](https://meta.discourse.org/u/Mittineague)
#### Post date: [January 8, 2018, 10:50pm UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/7 "2018-01-08T22:50:42Z")

</div>

It may be the path?

I see the missing translation on my localhost “goodguys” group when logged in as the non-Staff group owner.

`http://localhost/groups/goodguys/edit`

The “Add Members” input.

```plaintext
<input name="user-selector-renamed" 
 placeholder="[en.admin.groups.selector_placeholder]" 
 id="member-selector" class="ember-text-field ember-view" 
 style="width: 150px;" type="text"> 

```

These two are OK

```plaintext
<input name="flair_url" placeholder="(Optional) Image URL or Font Awesome class" id="ember1637" 
 class="ember-text-field ember-view" type="text"> 
<input name="flair_bg_color" placeholder="(Optional) Hex color value" id="ember1638" 
 class="group-flair-bg-color ember-text-field ember-view" type="text"> 

```

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [February 13, 2018, 3:13am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/8 "2018-02-13T03:13:11Z")

</div>

OH I just reviewed this again and think the change is correct (thought the github diff makes it very hard to understand)

What is happening is that you have a **non staff** group owner and need to allow the **public** group edit tab to work. It was sharing locale stuff with the **staff** locale file so it clearly fails.

@tgxworld can you review this and perhaps clean it up.

What we want to make sure is that we don’t have duplicate strings in admin/non-admin and duplicate templates here.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [February 26, 2018, 2:13am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/10 "2018-02-26T02:13:03Z")

</div>

Fixed in

[https://github.com/discourse/discourse/commit/3e1afbedc521a6687a9575b4319b821ada7f3bd1](https://github.com/discourse/discourse/commit/3e1afbedc521a6687a9575b4319b821ada7f3bd1)

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [February 26, 2018, 2:13am UTC](https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303/11 "2018-02-26T02:13:09Z")

</div>


