Moin
15 augustus 2024 om 09:16
1
No matter whether I click “Confirm” or “Revert”, the text in the composer is “SuperTool script” afterwards.
4 likes
keegan
16 augustus 2024 om 17:45
3
Thanks @Moin for catching this! This should now be resolved with:
discourse:main ← discourse:fix-diff-modal
opened 11:36PM - 15 Aug 24 UTC
In https://github.com/discourse/discourse-ai/pull/715, we refactored the compose… r helper menu to use `DMenu` instead of `popperJS`. Since the `AiComposerHelperMenu` component was an instance of `DMenu`, having modals defined in the component's template directly was likely resulting in various issues. For example, clicking anywhere on the `DiffModal` was closing the modal which led to issues such as [being unable to revert.](https://meta.discourse.org/t/the-revert-button-in-the-changes-popup-does-not-work/321783/2)
In this PR we update the usage of the Diff and Thumbnail Suggestion modals to be instantiated by the modal service using `this.modal.show()` instead of being directly defined in the template. This allows for the modals to work correctly.
3 likes
keegan
17 augustus 2024 om 15:00
5
This topic was automatically closed after 21 hours. New replies are no longer allowed.
