# Themes stop working if a child theme contains assets

**URL:** https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491
**Category:** Bug
**Created:** [06.Ноябрь.2017 07:29:59 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491 "2017-11-06T07:29:59Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![barryvan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/barryvan/32/82635_2.png) [@barryvan](https://meta.discourse.org/u/barryvan)
#### Post date: [06.Ноябрь.2017 07:29:59 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/1 "2017-11-06T07:29:59Z")

</div>

Steps to reproduce:

1. Create a new theme, and add some assets to it (for example, an image).
2. Save this theme.
3. Choose a different (parent) theme, and add the newly-created theme as a child to it.
4. Observe that the parent theme no longer works at all.

---

<div class="post-metadata">

### Author: ![barryvan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/barryvan/32/82635_2.png) [@barryvan](https://meta.discourse.org/u/barryvan)
#### Post date: [06.Ноябрь.2017 07:39:01 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/2 "2017-11-06T07:39:01Z")

</div>

This could cause issues with small “part” themes which need to be composed into larger ones to be useful. I ran into this creating a “Christmas hats” theme for December…

![image](https://global.discourse-cdn.com/meta/original/3X/f/8/f8d3290b331fb9896a2b44c54e81cecb80b41c19.png)

 ![image](https://global.discourse-cdn.com/meta/original/3X/1/9/196fb24a18127bdb97df6947cc49fab3bf480302.jpg) ![image](https://global.discourse-cdn.com/meta/original/3X/3/7/375b70258fad73d73a08aec549f532fc5f0736b0.jpg)

…which I had hoped to distribute here on Meta, as the lack of Christmas hats is clearly a _very_ significant oversight in core Discourse functionality. 😛

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [06.Ноябрь.2017 08:11:38 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/3 "2017-11-06T08:11:38Z")

</div>

Wasn’t this already reported @sam?

---

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [06.Ноябрь.2017 09:01:28 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/4 "2017-11-06T09:01:28Z")

</div>

Reported here

> [@Can't upload theme from file](https://meta.discourse.org/t/cant-upload-theme-from-file/73376):
>
> I just tried to import a theme from a file. When I select “from my device” I get the selector and choose the file, but then the “upload” button doesn’t do anything. I tested on two instances Discourse 1.9.0.beta13 and Discourse 1.9.0.beta14. Tested Chome and Firefox on Linux.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [06.Ноябрь.2017 10:44:08 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/5 "2017-11-06T10:44:08Z")

</div>



---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [06.Ноябрь.2017 12:37:37 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/6 "2017-11-06T12:37:37Z")

</div>

seems to be a different bug than the one linked above

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [14.Ноябрь.2017 04:24:07 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/8 "2017-11-14T04:24:07Z")

</div>

Good catch! This is fixed per:

[https://github.com/discourse/discourse/commit/075a4584896897d10389b40fa345e45df043f641](https://github.com/discourse/discourse/commit/075a4584896897d10389b40fa345e45df043f641)

Will look at deploying you later today!

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [15.Ноябрь.2017 07:00:07 UTC](https://meta.discourse.org/t/themes-stop-working-if-a-child-theme-contains-assets/73491/9 "2017-11-15T07:00:07Z")

</div>

This topic was automatically closed after 26 hours. New replies are no longer allowed.
