There was a problem sending another activation email


(Michael - DiscourseHosting.com) #1

Continuing the discussion from “There was a problem sending another activation email” and a pair of questions:

We’re getting this error as well in a few forums when you go to an unactivated user and hit the ‘resend activation email’ button. Activating and then deactivating the user account does not help.

It’s sending an empty POST to /users/username/send_activation_email and getting a 404 back.

production.log:

Started POST "/users/testuser/send_activation_email" for x.x.x.x at 2014-09-13 02:31:23 -0400
Processing by UsersController#send_activation_email as */*
  Parameters: {"username"=>"testuser"}
  Rendered exceptions/not_found.html.erb within layouts/no_js (15.1ms)
  Rendered common/_special_font_face.html.erb (1.3ms)
  Rendered common/_discourse_stylesheet.html.erb (6.2ms)
  Rendered layouts/_head.html.erb (8.7ms)
  Rendered text template (0.0ms)
Completed 404 Not Found in 50ms (Views: 0.8ms | ActiveRecord: 13.2ms)

There was a problem sending another activation email. http: undefined - undefined
(Jeff Atwood) #2

I can’t repro this on try.discourse.org

  • create new user in incognito window
  • do not activate account
  • switch to regular browser window
  • go to /admin/users, notice user is not activated (grey)
  • click “send activation email” button next to “active”

I get the email OK.


(Michael - DiscourseHosting.com) #3

Found it, it was fixed - we tested with stable

https://github.com/discourse/discourse/commit/c9262a839025e1436ac0e7b813134d8dccd939c5

But, why oh why wasn’t it included in v1.0.1 ?

Sam said

We will only backport urgent fixes between releases (on a case by case basis).

This seems like a pretty important fix to me.


(Michael - DiscourseHosting.com) #4

So @eviltrout, @sam, can we expect such fixes to be backported to 1.0.2 ?


(Jeff Atwood) #5

Does this affect all users or just the admin button?


(Sam Saffron) #6

Reading through the code, it looks like all users.


(Jeff Atwood) #7

If it affects all users I agree with @michaeld we should backport it.


(Sam Saffron) #8

Will leave it to @eviltrout then, I think his commit can be cherry picked, but would prefer if he merges it in, just in case.


(Robin Ward) #9

I’ve cherry picked it to the stable branch.


(Jeff Atwood) #10