>
>
> ื ืขืื ืืืืืจ!
> > ``` ### Before Discourse update TLP worked always well on our _external images_, whatever on topic creation or edition. However, we had the `download remote images to local` option disabled because of markdown issue. #### Markdown rendering issue This not the main issue, and it still happens after Discourse upgrade, here some explanation. When discourse downloads and replaces an image HTML with its markdown syntax โ in our context, this results as: ```plaintext [...][...] ``` Discourse is unable to render the image > **Image** > >  To fix the issue, you need at least an empty line above: ```plaintext [...] [...] ``` > **Image** > >  Would it be possible to allow rendering markdown image surrounded by HTML, please? ### After Discourse update - All thumbnails got deleted. - All images are well displayed in the topic content - Because of this feature ([FEATURE: Include optimized thumbnails for topics (#9215) ยท discourse/discourse@03818e6 ยท GitHub](https://github.com/discourse/discourse/commit/03818e642a1ae871bffdc0c39c10f05f0b8b0398), I think), we were forced to enable `download remote images to local` option as it would appear this no more possible to get a thumbnail from external linkโฆ ๐ - `download remote images max days old` is set to the max, 10000. > **Settings** > >  From this, I was told to rebake all posts to get the image downloaded. And itโs where it gets weird. 1. `rake posts:rebake` did not have much effect (at least not on the first message of a topic, but it did trigger a lot of `PullHotlinkedImages`) 1.1. Looking at some topics, I thought that the image HTML with `class` or `srcset` attributes were the cause, so I tried to normalize all the images with the following code (donโt know ruby) โ _It helped for some topics_. 1.2. However due to the markdown issue, I had to add newlines to fix. โ _At least for those topics, thumbnail worked._ > **Code** > > ```plaintext > Post.where(post_number: 1) > .where("raw LIKE '%
`, [link](https://zuzu.chat/t/topic/64467))
2. After normalizing, and seeing that an edit can help to download the image, I tried to `rake posts:rebake` multiple times โ _without effects_.
3. Then I tried to use the rails console similar to the code above but with _specific topic id_ and with only `post.rebake!` โ _without effects_
4. Not all images from a topic are always downloaded..
5. @Canapin points me to [Download remote images from older posts? - #3 by vinothkannans](https://meta.discourse.org/t/download-remote-images-from-older-posts/146134/3) ; trying to rebake all posts now. โ _Did not help unfortunately_
Itโs just crazy why some images works, others not. I donโt think itโs a criteria issue. Image settings are high. I really donโt understand what is the logic behind, this seems random.
Currently, we have still a lot of missing thumbnails. Likely most of them can be fixed manually with editing/saving, but thatโs not feasible. Iโm doing that for a client, and I have lost already a lot of time trying to fix the issue.
I donโt mind having upload images as thumbnail, but:
- Can you tell me if there are specific reasons why images wonโt download? Are there settings which can help? Do we need something? How to debug?
- Is there a way to force download them similar to editing/saving through the console?
- Can you allow markdown image rendering if surrounded by HTML?
Hopefully I was enough precise in the problem description.
Thanks in advance for any help and solution.
---
Hi @Arkshine, sorry to hear youโre having issues here. Unfortunately we canโt guarantee compatibility with all third-party plugins, especially where they override core behaviour beyond the scope of our plugin APIs. Going forward, TLP should able to reduce the number of core overrides it uses, and hopefully stability will improve.
Note that we now also have our [official solution](https://meta.discourse.org/t/topic-list-thumbnails-theme-component/150602) to displaying thumbnails, which is implemented entirely using our supported plugin APIs.
You are correct that core thumbnails only work for local images. Ultimately, TLP was pulling images and storing them locally as well, so the difference now is that weโre doing everything in a consistent way using the pull\_hotlinked\_images job.
It sounds like we have a couple issues to resolve here. I think it would be best to split them out so that we donโt miss anything. Reading through your post, I see two things:
> [@Arkshine](#):
>
> When discourse downloads and replaces an image HTML with its markdown syntax โ in our context, this results as:
>
> ```plaintext
> [...][...]
>
> ```
>
> Discourse is unable to render the image
> โฆ
>
> Would it be possible to allow rendering markdown image surrounded by HTML, please?
Pulling remote images shouldnโt result in invalid html/markdown, so we will try and get this fixed. Please go ahead and open a #Contribute > Bug topic, mention me, and weโll look into it.
> [@Arkshine](#):
>
> Some topic are ignored even after an edit. I can see `PullHotlinkedImages` is triggered but no images are downloaded. (like with this html ``
Again, special characters shouldnโt break the images here. Please open another #Contribute > Bug topic and weโll take a look.
---
Thanks for the response, @david.
About markdown, link with special characters, will do. Thanks.
* * *
_But_, ultimately, my main issue is still to make Discourse force-download the image. The markdown issue can be solved with console, and not all links have special characters. We have still a lot of topics without thumbnails. _This is on this Iโm asking help_.
For example, this one doesnโt have special characters. And unless I hit the `Save Edit`, the image is not downloaded through rebaking from the console, nor using the `Rebuild HTML` link.
Is there some rails command or something else which can force Discourse to download the image the same way as you would `Save Edit`?
* * *
Iโve actually tried to use the component, but it did not work well. But will give another go once the thumbnail issues are solved.
---
Is it an affiliate site?
---
> [@Arkshine](#):
>
> unless I hit the `Save Edit` , the image is not downloaded through rebaking from the console
That is strange. I have one idea - are these posts created by the system user? Or Discobot?
---
Most of them a normal admin user. Those topics are created through the API from [WP Discourse](https://github.com/discourse/wp-discourse).
For example this one:
---
@Arkshine was there supposed to be a link there?
---
Sorry, I was processing with an example, while testing things, but Iโve hit the button unintentionally.
Thatโs said, I started to execute this to see if it would help (sorry if it hurts your eyes!)
```plaintext
Post
.joins(:topic)
.where(post_number: 1)
.where('topics.visible = true')
.where('topics.deleted_at IS NULL')
.each do |post|
post.baked_version = nil
post.save!(validate: false)
post.rebake!
end
```
It took some times. Iโve seen quite a lot of `Jobs::PullHotlinkedImages`.
But it doesnโt seem It did not help much.
If you check a specific topic, for example, this [topic](https://zuzu.chat/t/sparkfox-sparkfox-k1-679-1-378/64215).
From the console, I can see it triggers `Jobs::ProcessPost` but not `Jobs::PullHotlinkedImages`
```plaintext
[106] pry(main)> Post.update_all(baked_version: nil)
=> 38808
[107] pry(main)> Post.where(post_number: 1, topic_id: 64215).each do |post| post.rebake!; end
=> [#![](\"https://zuzu.deals/wp-content/uploads/2020/05/5ebcf97155cd2-150x150.png\")
![](\"https://www.mooki.co.il/pub/media/catalog/product/cache/0f831c1845fc143d00d6d1ebc49f446a/_/s/_sparkfox_k1_5_.png\")
ืืื ืื ืืชื ืืืืืจืื ืืืื ืื ืืชื ืคืฉืื ืขืืืืื ืืืืฉืืื ืื ืืืื ืืืื ืืืจ ืืืขืง ืืืืกื ืืื ืืืชืจ, ืื ื ืืื ืขืื ืืืฆืข ืืืขืื ืืืืืจ ืืืืคื!
\nืืืกื ืืืืืื ื ืืคื ืง, ืืืื ืืืช ืืืืืื ื ืืืฉืืื ืืืืจ ืืืื ื, ืขื ืืืจืืืช ืืืืื ืจืฉืื – ืจืง ื679โช!!!
ืืฉืชืืฉื ืืงืืคื ืืงืืคืื ืืืืขืื – GLA679
\n![](\"https://zuzu.deals/wp-content/uploads/2020/05/90902-801-09_2_1.jpg\")
![](\"https://zuzu.deals/wp-content/uploads/2020/05/90902-802-08_3_1.jpg\")
\n", cooked: "
ืืื ืื ืืชื ืืืืืจืื ืืืื ืื ืืชื ืคืฉืื ืขืืืืื ืืืืฉืืื ืื ืืืื ืืืื ืืืจ ืืืขืง ืืืืกื ืืื ืืืชืจ, ืื ื ืืื ืขืื ืืืฆืข ืืืขืื ืืืืืจ ืืืืคื!
\nืืืกื ืืืืืื ื ืืคื ืง, ืืืื ืืืช ืืืืืื ื ืืืฉืืื ืืืืจ ืืืื ื, ืขื ืืืจืืืช ืืืืื ืจืฉืื โ ืจืง ื679โช!!!
ืืฉืชืืฉื ืืงืืคื ืืงืืคืื ืืืืขืื โ GLA679
\n\n
\n", created_at: Thu, 14 May 2020 07:55:31 UTC +00:00, updated_at: Tue, 26 May 2020 14:56:16 UTC +00:00, reply_to_post_number: nil, reply_count: 0, quote_count: 0, deleted_at: nil, off_topic_count: 0, like_count: 0, incoming_link_count: 2, bookmark_count: 0, score: 10.8, reads: 4, post_type: 1, sort_order: 1, last_editor_id: -1, hidden: false, hidden_reason_id: nil, notify_moderators_count: 0, spam_count: 0, illegal_count: 0, inappropriate_count: 0, last_version_at: Thu, 14 May 2020 09:19:26 UTC +00:00, user_deleted: false, reply_to_user_id: nil, percent_rank: 0.0, notify_user_count: 0, like_score: 0, deleted_by_id: nil, edit_reason: nil, word_count: 939, version: 3, cook_method: 1, wiki: false, baked_at: Tue, 26 May 2020 16:59:49 UTC +00:00, baked_version: 2, hidden_at: nil, self_edits: 2, reply_quoted: false, via_email: false, raw_email: nil, public_version: 3, action_code: nil, image_url: "https://zuzu.deals/wp-content/uploads/2020/05/5ebcf97155cd2-150x150.png", locked_by_id: nil, image_upload_id: nil>] ``` * * * If I `Save Edit` from composer: I see well  Then I can see the image is downloaded:  --- > [@Arkshine](#): > > I can see it triggers `Jobs::ProcessPost` but not `Jobs::PullHotlinkedImages` Ah I see. The problem here is > [@Arkshine](#): > > ```plaintext > last_editor_id: -1, > > ``` Because we have this logic before scheduling pull hotlinked images: >