خطأ في المنطقة الزمنية

ted · 12 يناير 2023، 10:58ص

تم إصلاح هذا في PR#19477.

github.com/discourse/discourse

FIX: Remove magic time ranges

main ← Drenmi:fix/remove-magic-time-ranges

opened 06:30AM - 15 Dec 22 UTC

Drenmi

+91 -9

### History In #15474 we introduced dedicated support for date ranges. As par…t of that change we added a fallback of "magic" date ranges, which treats dates in any paragraph with _exactly_ two dates as a range. There were discussions about migrating all such paragraphs to use the new date range element, but it was ultimately decided against. ### What's the problem? 1️⃣ A minor [bug](https://meta.discourse.org/t/timezone-bug/248674) was reported relating to the "magic" date range. If a Tippy was already open when expanding a date, the date would be considered a single date, but if no Tippy was open, it would be considered a range. So expanding the same date could have different results based on the initial conditions. (The reason this happened is the fallback relies on the number of elements in the paragraph being exactly 2, but the Tippy element was also added as a child of the same paragraph, resulting in 3 children.) 2️⃣ While working on this, I additionally found that using two date ranges in the same paragraph would result in all dates in the paragraph being treated as single dates, rather than being grouped together in ranges. ### How does this fix it? Firstly, we remove the fallback to "magic" date ranges, as decided. This fixes the 1️⃣ problem. Secondly, when looking at an element and it's parent paragraph, we now select all date range children and partition them two-by-two. This fixes the 2️⃣ problem. ### In summary - Single dates are now always rendered as single dates. - Multiple date ranges in the same paragraph now works correctly. ### In action ![discourse-date-ranges](https://user-images.githubusercontent.com/5259935/207788658-f754ab5e-53bb-40a2-83c6-57ad2334f63d.gif)

الموضوع		الردود	مرات العرض
Wrong time when using the date picker: bug? Bug	20	2000	5 ديسمبر 2020
Ignore user date range seems buggy in Safari or Firefox on touchscreen desktop Bug	2	511	15 أغسطس 2023
Change timestamp button partially obscured UX	4	1213	26 فبراير 2018
Local-dates displaying incorrectly Bug	2	649	5 يوليو 2018
Date ranges breaks checklists Support checklist	2	288	19 أبريل 2024

خطأ في المنطقة الزمنية

الموضوعات ذات الصلة