Titles are missing from emails when names are de-duped


(Allen - Watchman Monitoring) #1

Continuing the discussion from Full names aren't shown even when they don't match username

In the image below, you’ll see that Dan Ant has his title on the left, in the web, but it’s missing on the right in the email.

His full name is missing on the left, due to deduplication


(Jeff Atwood) #2

We should unify this code path @eviltrout so we are not doing it in so many places. The string that appears next to an avatar should be produced from the same function (minus CSS styles of course).


(Robin Ward) #3

This is one of those places we can’t, as the emails are generated in 100% ruby code and the front end is Javascript.

We could break and call JavaScript like we do for rendering text, but that is quite complicated to do for this small use case.


(Sam Saffron) #4

that said we are starting to get a use case for a helper that “inlines” css, cause managing that part in mail is getting real cumbersome


(Allen - Watchman Monitoring) #5

Related, but not worth a separate thread:

I’m seeing that the emails are properly[sic] showing both names, when there isn’t an exact match, while the web-ui shows only the shortname.


(Jeff Atwood) #6

It’s worse than that, on community.imgur.com for example, my notification emails include the full name, title, etc even though the site is not configured to show names on posts.

Example:

versus in email…

We really need to fix some of this @eviltrout.


(Robin Ward) #7

I committed a couple of fixes for the issues in this topic. I couldn’t reproduce the title not showing up but I suspect that may be because it was fixed with one of these commits. If not please let me know and we’ll figure it out:

https://github.com/discourse/discourse/commit/388f51eed7006bc2057e77fcda87a4b22f1ea12c

https://github.com/discourse/discourse/commit/5c7d6e0a3c4507d06f79450d87a4323afd7c492b