הפעל או כבה את Whisper :עין:

רכיב ערכת נושא
28

Sorted. This is now with the original author who can take this forward.

2 לייקים
29

Thanks for sorting that out. :pray: :slight_smile:

3 לייקים
30

@ganncamp
I’ve fixed the immediate issue. There’s one caveat though. Currently the Discourse backend only supports staff users to be able to switch a post’s post_type so I have made the :eye: toggle icon to to appear if a user is in whispers_allowed_groups and also a staff member. Do let us know your thoughts on this.

3 לייקים
31

I appreciate the effort. I came up with came up with a solution which reduces the complexity a bit. Also thanks for pointing out the actual cause.

2 לייקים
32

That’s fine for us; only staff can see whispers.

And… I’m not seeing this on my instance yet…?

לייק 1
35

And now it works! Thanks!

2 לייקים
36

image
Breaking change on new version of discourse

5 לייקים
39

I recently ran into the same problem as well, so I rewrote the component and made a PR. Pull requests · fzngagan/discourse-toggle-whisper

@fzngagan Can you take a look at it?

11 לייקים
40

Just tested it and it works like a charm. The code looks nice too. Thanks so much for this, it save me a bunch of work. Merged :tada:

5 לייקים
41

image
image1288×125 4.04 KB

It does have some issues though, when not logged in.

it causes much more than just 1 error also.

3 לייקים
42

I made a quick PR to fix the issue :+1: (@fzngagan)

5 לייקים
43

Nice one! i love coding… a simple ? and the problem is solved :joy:

image
image415×189 2.35 KB

3 לייקים
44

הסמל של ההודרה toggle כבר לא מופיע באתר שלנו יותר, אנחנו רץ על 3.4.1. מישהו אחר נתקל באותה בעיה?

45

@fzngagan heads up on a 404 link here:

Screenshot 2025-05-29 at 09.59.57
Screenshot 2025-05-29 at 09.59.571348×1148 82.1 KB

46

There’s a potential leak here whereby some users can still visibly see the whispered posts.

Steps to replicate:

  1. Without whispering, reply direct to or quote a user in a post/reply
  2. Change the post to a whisper
  3. The @mentioned / @quoted user can still visibly see the whispered post
47

אני לא חושב שאני יכול לשחזר את זה?

השלבים שלי כדי לראות אם אני עושה שטות :derp:

  • Test_One יוצר פוסט על ידי מענה ישיר ל-Test_Two
  • זורק גם ציטוט של Test_Three ו-@אזכור של Test_Four
  • בתור מנהל מערכת, מעביר את הפוסט הזה ללחישה (whisper)

האנשים היחידים שיכולים לראות את הלחישה הם מנהל המערכת ו-Test_One (וזה צפוי, כי אתה יכול לראות את פוסט הלחישות שלך גם אחרי שאתה כבר לא יכול ליצור לחישות)

האם זה קשור לטעינת דף מחדש?

לייק 1
48

I’ll check with my colleague who reported the issue to confirm, but:

Is Test_One an admin? :thinking:

49

No, just a normal non-staff user.

Does it need to be an admin and/or mod?

ETA: re-running the test using an admin to create the direct reply (with quote + mention) seems to be offering similar results.

There is a ux oddity in that each of these test users got a notification for the respective things, and when followed the post was no longer there for them to see.

There’s also another ux one for the expandable ‘x replies’ box where the count includes the whisper, but doesn’t show it when expanded.

לייק 1
50

Unsure, we’ll do some more testing and report back, thanks :smiley:

לייק 1
51

This is now no longer the case :tada:

5 לייקים