# Toggling staff color on a post doesn't get applied when done as TL4 user

**URL:** https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620
**Category:** Bug
**Created:** [January 30, 2015, 6:16pm UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620 "2015-01-30T18:16:31Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![anon42064797](https://avatars.discourse-cdn.com/v4/letter/a/dec6dc/32.png) [@anon42064797](https://meta.discourse.org/u/anon42064797)
#### Post date: [January 30, 2015, 6:16pm UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/1 "2015-01-30T18:16:31Z")

</div>

I opened the wrench menu, clicked “Add Staff Color” and opened it again shortly after that:

 ![](https://global.discourse-cdn.com/meta/original/3X/c/0/c092e2ada67b8f6191f14a142b49a07e69222378.png)  
As you can see, the post turns yellow, but the button still says “Add Staff Color”.  
When I reload the topic, the yellow color disappears:  
 ![](https://global.discourse-cdn.com/meta/original/3X/e/b/ebb346f7fc9254d895508dde6d70130adb8cc6c6.png)  
Same thing applies when trying to “Remove Staff Color” from posts.

Moderators don’t suffer from this issue, apparently.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [January 30, 2015, 11:39pm UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/2 "2015-01-30T23:39:22Z")

</div>

Seems like a legit bug, can you take it monday @techAPJ?

---

<div class="post-metadata">

### Author: ![PJH](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pjh/32/39071_2.png) [@PJH](https://meta.discourse.org/u/PJH)
#### Post date: [January 31, 2015, 2:46pm UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/3 "2015-01-31T14:46:46Z")

</div>

Experimentation indicates that it’s only TL4’s with this issue. Mod-only, Admin-only and Mod+Admin don’t.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [February 1, 2015, 5:00am UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/4 "2015-02-01T05:00:33Z")

</div>

I don’t know that TL4 should even have this function, it is called “staff color” for a reason.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [February 1, 2015, 6:55am UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/5 "2015-02-01T06:55:54Z")

</div>

I agree, I think the bug here is that we are allowing non-staff to set staff colors.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [February 1, 2015, 7:47pm UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/6 "2015-02-01T19:47:53Z")

</div>

Sent a fix for “text not changing for button when adding staff color” issue (this was affecting all users: TL4, Mod-only, Admin-only and Mod+Admin).

[https://github.com/discourse/discourse/pull/3156?1](https://github.com/discourse/discourse/pull/3156?1)

Edit: ~~“Not allow TL4 user to set staff color” issue is a WIP.~~ Done!

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [February 2, 2015, 5:12am UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/7 "2015-02-02T05:12:49Z")

</div>

Okay, now TL4 user will not be able to see the “Add Staff Color” button 🐛

[https://github.com/discourse/discourse/pull/3158](https://github.com/discourse/discourse/pull/3158)

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [February 2, 2015, 5:29am UTC](https://meta.discourse.org/t/toggling-staff-color-on-a-post-doesnt-get-applied-when-done-as-tl4-user/24620/8 "2015-02-02T05:29:14Z")

</div>


