Happy to look at that right now: do you have an error in the console? PM me a link to the site if you like.
(FYI resolved)
2개의 좋아요
This is now merged. You should now use the regular master branch.
https://github.com/merefield/discourse-topic-list-previews-theme/pull/5
Let me know if you have any issues.
1개의 좋아요
A few changes have been made to make the TC compatible with Ember-CLI changes:
3개의 좋아요
FYI, the known scrolling issue with the TC in Chrome appears to have been resolved in the Beta version of Chrome (V 96) - the next major version of Chrome.
Therefore this is a heads up that I’m probably not going to put the effort into updating the large plugin version to support Ember CLI and request that you move to the TC version of this “plugin” which is in any case much faster, more up-to-date and supports responsive widths.
I may close this topic and create a new one in Customization > Theme at that point.
Please do let me know if you have any special dependency on the plugin.
5개의 좋아요
@merefield
Thank you Robert! And to be sure - what about the plugin version that supports TC - should we continue to use it?
2개의 좋아요
Good point. I’ll continue to support the “side car” plugin element so that we maintain feature parity.
3개의 좋아요
To make sure everyone is aware of this change, maybe you could add an admin dashboard warning for anyone that is currently using the plugin? You can see an example of this in our old slack plugin.
That message could include instructions on how to get set up with the theme component and sidecar plugin.
4개의 좋아요
Great idea @David, thanks
4개의 좋아요
It is a great news and I am switching the Plugin back to TC. 
I found that the “Like” button in Tile view may not response when using the “TC + sidecar”. I can click on it to add Like but if I click again the like won’t remove. The Plugin version have no such problem.
Also sometime error message pop out when pressing the “Like” button.
I have tested your demo website and it act the same as well.
https://rideables.tech/
2개의 좋아요
That looks like a regression. That’s for making the effort to include a video clip.
2개의 좋아요
Reminder: Please replace the plugin with the TC
NB: There is still a known issue with the TC in Chromium-based browsers where scrolling eventually spoils the layout, but this is fixed in Chrome Beta and the update is imminent.
3개의 좋아요
I enabled the theme component and the side car plugin. It is working fine, however the topic page doesn’t seem to have the featured image list at the top. I also can’t find the setting to enable it on the single topic page in the theme component settings. Is showing featured image on the topic page not supported?
2개의 좋아요
That’s correct, it’s no longer currently supported.
I suspect I removed it due to the original constraints of it being a TC, which prevents me altering the Topic Serializer.
I will look to add it back in in a future update when I have time (as part of the sidecar plugin extensions)
1개의 좋아요
I’ve added a quick fix to un-liking. It’s not perfect but should work in most circumstances.
FIX: inability to unlike · merefield/discourse-tc-topic-list-previews@cbedcba · GitHub
2개의 좋아요
Just want to let everyone know, the Chrome 96 Stable has just released today. 
I just updated the stable version and I can confirm that the TC overlapping layout issue has been solved. 
Thank you very much @merefield 
3개의 좋아요
Yep, awesome. Edge should not be far behind.
Now we just want, I don’t know?: native CSS for masonry grids for ultimate performance 
(Not necessary, but a nice-to-have to reduce javascript)
I suspect the extra support from Microsoft is bearing fruit for Chromium now.
3개의 좋아요
I have enabled the TC and the sidecar plugin on krita-artists.org. And sometimes when I go back to home page by clicking on the logo the top row of featured image doesn’t show up. I have to reload to make it appear. I am using firefox.
1개의 좋아요
Working for me on your site. But I’m an anonymous user.
Cannot repro on my test sites either.
Do you see an error in the console?
1개의 좋아요
There is no message or error in console. Yes this happens when I am logged in. To reproduce it I go a topic from the landing page and then come back to the landing page by clicking on the logo. If do a soft reload then the featured image appears.
1개의 좋아요
Still cannot reproduce.
- Opened Firefox
- Navigated to your site
- Created an account
- Went to a Topic
- Hit the logo
- Categories page opens and Featured Images load.
1개의 좋아요