Onderwerplijstvoorbeelden (TLP)

Customization Thema component
388

Thank for the quick reply,

That is a bit unfortunate indeed. I do not have the funds to sponsor this now. But I will try to raise something if possible. May I know (in private message may be) what would be an approximate estimate for this task?

1 like
389

Iā€™ll drop you a line :+1:

390

Thank you for the awesome plugin! But there are some issues I canā€™t deal with. Iā€™m not sure if these are bugs or caused by wrong settings.

  1. When I tried to go back to the topic list, the scrollbar will return to somewhere else instead of the last visit part.
    2.I tried to enable topic list action and they look fine. However, it randomly highlights the bookmark button, even though the topic has not actually been added to bookmarks.
391

Thatā€™s currently not supported. PR welcome

Thatā€™s very odd, I cannot presently reproduce - are you on latest version of Discourse?

392

https://github.com/paviliondev/discourse-tc-topic-list-previews/pull/34/files

@Niels_Dewitte sorry this took so long, but a PR was always welcome to fix this.

Thanks again for the report. This should be resolved now.

2 likes
393

Hi, how do I use the thumbnail picker in GitHub - merefield/discourse-topic-previews-sidecar: A Discourse plugin that complements the Topic Previews Theme Component to add features Ā· GitHub?

2 likes
394

Itā€™s a button in the topic meta editor:

image
image742Ɨ452 54.9 KB

1 like
395

This button is not shown on my discourse forum, iā€™m currently using:

Installed

3.2.0.beta4-dev

(d03f6727b1)

1 like
396

I have, and I rebuilded few hours ago.

IMG_2666
IMG_26661461Ɨ428 83.4 KB

I know. That doesnā€™t help you a bit, but it means your issue isnā€™t by some general bug.

2 likes
397

@merefield

I noticed that your recent changes from two weeks ago removed the usage of the Ember global. However, it will fail if you use Ember 5!
For example:

image
image831Ɨ128 6.21 KB

Suggestions:

  • computed.bool ā†’ bool ā†’ @ember/object/computed
  • run.scheduleOnce ā†’ scheduleOnce ā†’ @ember/runloop
3 likes
398

Nice catch @Arkshine! This deprecation is deprecated-run-loop-and-computed-dot-access. Messages about that wouldā€™ve shown up in development and test environments, but it looks like they were being optimised out of the production build.

This will make the warning work in production builds of Discourse under Ember 3.28:

https://github.com/discourse/discourse/pull/25074

(by default Ember optimises all deprecations out the production build, so we have a to do a lot of work to undo those optimisations)

4 likes
399

Thanks David. Yeah that would be why I will have missed them. As a Theme Component I generally check for deprecations against a current Production build as I use the Theme CLI (and none of my Production builds are running Ember 5 just yet so ā€¦).

Great catch @Arkshine !

2 likes
400

What does the after_code section of your app.yml look like?

401

Those were indeed good suggestions :+1:

https://github.com/paviliondev/discourse-tc-topic-list-previews/commit/640580b248ee6f5ab0606dd28c9c30d32b2711fa

I also found:

https://github.com/paviliondev/discourse-tc-topic-list-previews/commit/7c961aaec887f7f2951b4f1006164ad67bc6dc65

Let me know if you see any additional problems.

1 like
402

Hi, here it is:

image
image703Ɨ425 7.65 KB

2 likes
403

Ok thatā€™s odd. Any errors in logs? Both console and server logs?

404

What would I be looking for ? I donā€™t have any error showing for the plugin. Topic Previews Sidecar

The installed version is:
5.0.2 f303e4f

The settings being used is:

image
image681Ɨ927 52 KB

1 like
405

Do you have Theme Component active in the current Theme? (you must have the Theme Component as well as the plugin running)

2 likes
406

Iā€™m using the blog style on two categories and tags, so yes itā€™s active. Let me try a different theme as iā€™m using the Kodular Community Theme

1 like
407

And youā€™ve hit the pencil control to edit the Topic category, title and tags?