게시물 목록 미리보기(TLP)

Hi, It doesn’t show up with the thumbnail icon, it’s not rendered in the html either. I also tried the default discourse theme.

1개의 좋아요

I think you may need a freelancer to take a closer look.

I have had no other reports. Very strange.

Thanks, it’s not really mandatory for me. I’ll just disable it, I only asked here given I thought I was missing to do something else.

2개의 좋아요

Before I move on from this can you please share your console from this view? Any warning or something red?

Just to give you some clarity: the Theme Component is what provides the thumbnail selector UI but this is only activated if the plugin is detected.

1개의 좋아요

These are all the warnings in my logs, there isn’t anything in red at the moment.

Deprecation notice: `SiteSetting.min_trust_to_flag_posts` has been deprecated. Please use `SiteSetting.flag_post_allowed_groups` instead. (removal in Discourse 3.3) At /var/www/discourse/lib/site_set

10:19 am

Deprecation notice: `SiteSetting.min_trust_level_to_allow_user_card_background` has been deprecated. Please use `SiteSetting.user_card_background_allowed_groups` instead. (removal in Discourse 3.3) A

10:19 am

Deprecation notice: `SiteSetting.min_trust_level_to_allow_ignore` has been deprecated. Please use `SiteSetting.ignore_allowed_groups` instead. (removal in Discourse 3.3) At /var/www/discourse/lib/sit

10:19 am

Deprecation notice: `SiteSetting.min_trust_level_to_allow_ignore` has been deprecated. Please use `SiteSetting.ignore_allowed_groups` instead. (removal in Discourse 3.3) At /var/www/discourse/lib/gua

3:59 pm

Deprecation notice: `SiteSetting.min_trust_to_edit_post` has been deprecated. Please use `SiteSetting.edit_post_allowed_groups` instead. (removal in Discourse 3.3) At /var/www/discourse/lib/guardian/
2개의 좋아요

I’ve disabled majority of my plugins and tried three different themes under preview and it it didn’t show the selector so I’m unclear as to what could be the problem.

1개의 좋아요

Try a completely fresh install at some point (not for production) and see if you can replicative the issue.

So far I’ve been unable to.

1개의 좋아요

I also can’t reproduce it on my side. That’s odd. Looking at the code, it should be working as long as the TLP component and plugin are enabled. :thinking:

2개의 좋아요

Similarly, I get 2 different warnings.

this is one:

Message

Deprecation notice: `SiteSetting.min_trust_to_edit_post` has been deprecated. Please use `SiteSetting.edit_post_allowed_groups` instead. (removal in Discourse 3.3) 
At /var/www/discourse/app/models/concerns/limited_edit.rb:19:in `trusted_with_edits?`

Backtrace

/var/www/discourse/lib/discourse.rb:1035:in `deprecate'
/var/www/discourse/lib/site_settings/deprecated_settings.rb:128:in `block (2 levels) in setup_deprecated_methods'
/var/www/discourse/app/models/concerns/limited_edit.rb:19:in `trusted_with_edits?'
/var/www/discourse/app/models/concerns/limited_edit.rb:7:in `edit_time_limit_expired?'
/var/www/discourse/lib/guardian/post_guardian.rb:177:in `can_edit_post?'
/var/www/discourse/lib/guardian.rb:670:in `public_send'
/var/www/discourse/lib/guardian.rb:670:in `can_do?'
/var/www/discourse/lib/guardian.rb:208:in `can_edit?'
/var/www/discourse/app/serializers/post_serializer.rb:165:in `can_edit'
(eval):34:in `_fast_attributes'

this is the other one:

Message (2 copies reported)

Deprecation notice: `SiteSetting.min_trust_level_to_allow_ignore` has been deprecated. Please use `SiteSetting.ignore_allowed_groups` instead. (removal in Discourse 3.3) 
At /var/www/discourse/lib/guardian.rb:560:in `can_ignore_users?`

Backtrace

/var/www/discourse/lib/discourse.rb:1035:in `deprecate'
/var/www/discourse/lib/site_settings/deprecated_settings.rb:128:in `block (2 levels) in setup_deprecated_methods'
/var/www/discourse/lib/guardian.rb:560:in `can_ignore_users?'
/var/www/discourse/lib/guardian.rb:555:in `can_ignore_user?'
/var/www/discourse/app/serializers/user_card_serializer.rb:134:in `can_ignore_user'
(eval):15:in `_fast_attributes'
active_model_serializers-0.8.4/lib/active_model/serializer.rb:456:in `attributes'
active_model_serializers-0.8.4/lib/active_model/serializer.rb:480:in `_serializable_hash'
active_model_serializers-0.8.4/lib/active_model/serializer.rb:359:in `serializable_hash'
active_model_serializers-0.8.4/lib/active_model/serializer.rb:343:in `as_json'

Can you please elaborate on what this has to do with Topic List Previews?

I didn’t mean it was about Topic List Previews. I also encounter similar problems in the log section. I wrote that maybe the problems have something in common.

1개의 좋아요

Can you reproduce this users issue with TLP?

I’ve finally released a fix for this (on the sidecar):

https://github.com/paviliondev/discourse-topic-previews-sidecar/commit/119e756616e4fdfbc446bd3c73a176e69d9e8008

https://github.com/paviliondev/discourse-topic-previews-sidecar/commit/238146dd8728919fb308bffa2b1527db2aebc21d

Now when topic_list_enable_thumbnail_recreation_on_post_rebuild is set, normal Topic images should not be disappear :slight_smile: (the image was never destroyed, only it’s optimized image which can be recreated on rebake)

This feature was intended to support recreation of thumbnails for YouTube embeds to eliminate letterbox borders.

(The interim workaround was to turn that setting OFF - it was in any case marked as “experimental”).

Sorry that took so long, it was on my list!

You will need to update the sidecar plugin to get this fix.

@STORMS @Jagster

3개의 좋아요

Another fix FYI, dominant colour presentation was incorrect when one of the RGB colour elements was zero - this is now fixed :sweat_smile: :

https://github.com/paviliondev/discourse-tc-topic-list-previews/commit/832a25db9639dc4abba2afd9049d2b952f0304ac

2개의 좋아요

Yeah, only enable this momentarily when you need it, rebuild the desired Topic Post, then immediately switch it off. It’s fiddly and probably should have a UI control on the Topic Post itself, but it makes for a much nicer view when you don’t have black borders on Youtube videos.

3개의 좋아요

Hi, we’ve been using this theme component for a while and it’s really helpful for our community since it’s very visual heavy.

However, we’ve been running into performance issues with this plugin. When we turned it off, we went from 100% CPU and issues with loading the page to ~55% CPU usage.

Any idea on how we can keep the plugin on without the massive performance hit?

1개의 좋아요

Can you share how you configured the component? It might help to figure out the
context.

Did you notice the CPU spike the first time you installed this component?

2개의 좋아요

I do not remember CPU usage when it was first installed unfortunately.

The Component settings I’ve overridden

  • topic list tiles topic lists (removed all selections)
  • topic list thumbnails categories - added 6 categories we want previews in
  • topic list excerpts topic lists - (removed all selections)
  • topic list actions topic lists - (removed all selections)
  • topic list portfolio filter type - category
  • topic list portfolio filter parameter - scripts category

The plugin seems to have no settings overridden except that we’ve turned it off for now.

1개의 좋아요

Your server’s CPU? Can you share your CPU specs?

I assume you mean with the sidecar plugin installed?

I checked a site with this running on a Raspberry Pi :sweat_smile: in Chrome and I couldn’t identify any specific performance issue locally on the client.

I have a VPS with 4GB running with both the plugin and the Theme Component on clients and a page refresh causes a blip to 25% on one core, but nothing more

2개의 좋아요

We’re using the 2nd highest tier DO basic droplet, premium AMD cpus.

I’m going to reenable topic list previews for 24hr just to see if it makes cpu spike up again or not.

1개의 좋아요