תצוגות מוקדמות של רשימת הנושאים (TLP)

[merefield (Robert)]

Well, it looks like that Component has yet to be updated for Glimmer Topic Lists in any case:

Show both OP and last reply on mobile

[Admin Notice: On the dark red background image, a notice states that a theme or plugin needs updating due to upcoming Discord core changes, specifically mentioning the "Topic OP and last reply for mobile" theme with the ID "discourse.hbr-topic-list-overrides". (Captioned by AI)] Will this theme component be updated?

[Jagster (Jakke Lehtonen)]

I use so rarely a phone, but I’m quite sure this is part of this conversation. I upgraded quite late yesterday and users started complain. And I took your fix few minutes ago. The theme is Discourse default.

I checked here and I’m almost sure latest avatar wasn’t in use here either.

It just not look nice. But It isn’t just yours issue, both of similar components are now showing both avatar and thumbnail. Sure, I know how to hide avatars, so it is easy solution.

Honestly, I don’t know if here is not anything more than (my) matter of taste. But something has changed, otherwise my users wouldn’t start asking. I’m a bit early now, because up here it is just 6 o’clock and I haven’t yet got any confirmations what is actually off.

[merefield (Robert)]

This is not intended and imho it looks terrible, but I cannot reproduce.

As per my screenshot this isn’t happening on my instances.

Please make sure there are no other components active that influence the topic list presentation. This is now an API and other components can interfere if active. Then see if it persists. Then share your settings if it does.

[merefield (Robert)]

And btw, this theme component was never designed to be compatible with any other component that influences the Topic list so feel free to experiment combinations but there is no guarantee.

[Jagster (Jakke Lehtonen)]

@merefield

but I cannot reproduce

Of course I forgot to tell this, but I tried it right away as the only component. Because I trust you are on latest Discourse, I have to ask do you think is there a chance it comes from some plugin?

[merefield (Robert)]

זה עשוי להיות מקרה קצה שפיספסתי. האם תוכל לשתף את ה-HTML של פריט רשימת נושא אחד (כל השורה)?

או שלח לי בהודעה פרטית את הקישור לאתר

[Jagster (Jakke Lehtonen)]

This much?

html snippet

<tr data-creator-name="Jagster" id="ember42" class="topic-list-item category-chattifoorumi tag-meemit has-excerpt visited ember-view">
<div class="hidden">
<div class="hidden">
<td class="topic-list-data">
<div class="pull-left">
<a href="/t/meemit-ja-muut-tuplavitsit/1263/549" aria-label="User Jagster's profile, last poster" data-user-card="Jagster">
<img alt width="48" height="48" src="/user_avatar/foorumi.katiska.eu/jagster/96/6057_2.png" class="avatar" title="Jagster">
</a>
</div>
<div class="topic-item-metadata right">
<span id="_render_glimmer_25" class="hbr-ember-outlet">
<div class="topic-thumbnail">
<a>
<img class="thumbnail non-tiles-thumbnail" src="https://cdnfoorumi.katiska.eu/optimized/2X/b/b5fdeed33ad48a86cc12ecb1fb0acfc55f62247c_2_536x800.jpeg" loading="lazy">
</a>
</div>
</span>
<div class="main-link">

Oh god… that looks bad. Hard to read.

Well, url is public anyway and I don’t think a full Finnish forum wakes any interest — and in the case someone sees a link as spam, editing it afterward is easy.

https://foorumi.katiska.eu (let’s not wake automatic systems) and scroll some lines. You find it. And if you want cleaner view, theme test is a good option.

[merefield (Robert)]

Perfect.

The line with the issue is this:

<tr data-creator-name="Jagster" id="ember42" class="topic-list-item category-chattifoorumi tag-meemit has-excerpt liked visited ember-view">

that class should contain has-thumbnail for the CSS to hide the avatar …

let me double check this assignment is working on the very latest discourse.

[Jagster (Jakke Lehtonen)]

Basically it does same, but shorter and conditionally, what I used for mobiles?

.topic-list td div.pull-left a {
    display: none;
}
.topic-list td div.right {
    margin-left: 0px;
}

[merefield (Robert)]

Yes:

mobile/mobile.scss

[merefield (Robert)]

עדיין לא מצליח לשחזר את הבעיה שלך באחרון ביותר של ההתחייבויות, גם ב-Latest בבית וגם בקטגוריה. :עצוב:

ודא שההגדרה של רשימת הנושאי Glimmer פעילה, ולא אוטומטית?

[Jagster (Jakke Lehtonen)]

It is on auto I’ll change it.

edit

o damn — it was that.

So auto, that includes enabled, is not same as enabled. Is there some mechanism that need explicity tell glimmer is ok, unless it falls back to old system?

[merefield (Robert)]

That’s very useful info.

And surprising! At least my setup instructions were correct

I’ll check with David.

[merefield (Robert)]

For now, there’s this:

@david

auto: will detect the compatibility of your current plugins and themes. If any are incompatible, it will use the legacy system; otherwise it will use the new implementation.

I believe it thinks something is not compatible, so it falls back to old system.

[david (David Taylor)]

Yup exactly. “Auto” will be the same as “enabled” if all your installed themes and plugins are compatible with the upgrades.

If they’re not compatible, then it will act like “disabled”, and a message will be printed to the browser console explaining which theme/plugin needs to be upgraded.

For our official themes/plugins, we’ve made them compatible with both old and new topic-list implementations simultaneously, so that people can upgrade other themes and plugins one-by-one without needing to worry about the site setting. The implementation switch will then happen automatically once the last theme/plugin is ready.

But, ensuring that backwards-compatibility is a lot more work, especially for complex cases. So I can see why it’s been skipped for topic-list-previews

One thing you could do here @robert is add a clear error for people? Something like

import { withSilencedDeprecations } from "discourse/lib/deprecated";

...

withSilencedDeprecations("discourse.hbr-topic-list-overrides", () => {
    api.modifyClass("component:topic-list", {
      init(){
        alert("topic-list-previews cannot be run alongside other themes/plugins which are incompatible with the glimmer topic list. See https://meta.discourse.org/t/209973/521 for details");
        return this._super(...arguments);
      }
    });
  });

That will modify the old topic list to pop an error if it’s rendered while topic-list-previews is running.

[merefield (Robert)]

Extremely useful, thanks, I’ll add.

Yes, I have to be rational about how much time I spend so backwards compatibility was dropped.

However, the update is pinned, so a half-way house.

[Don]

תודה דוד, השתמשתי בזה בקומפוננט הנושא שלי. אבל לפני כן מצאתי את זה במאגר הפלאגין הפתרון, השתמשתי ב-site.useGlimmerTopicList שנראה שגם עבד. האם זה גם אפשרות טובה? השתמשתי בכך באיניטיאלייזרים ובתבנית.

[david (David Taylor)]

[ציטוט=“דון, הודעה:547, נושא:209973”]
שימוש ב-site.useGlimmerTopicList נראה שגם עבד. האם זה גם אופציה טובה?
[/ציטוט]
זה בסדר לעכשיו, אבל זה יוסר (כלומר יהפוך ל-undefined) כאשר רשימת נושאי הגימר תהיה האפשרות היחידה. לכן ודא שאתה משתמש ב- זה כמו

if(!site.useGlimmerTopicList){
  // לעשות את הדברים הישנים
}

ולא כמו

if(site.useGlimmerTopicList){
  // לעשות את הדברים החדשים
}

[merefield (Robert)]

@david

import { withSilencedDeprecations } from "discourse/lib/deprecated";

btw, added:

IMPROVE: add alert for Glimmer Topic List compliance

very much appreciated.

@Jagster if you have time could you please update, set to Auto and check if this pops up?

[merefield (Robert)]

btw, @david FYI, also needed eslint suppression I think? (and pluginId)

add eslint exception for alert