Topic List Previews


(Pad Pors) #223

thanks Angus :slight_smile:

another issue: the last poster avatar is showing randomly on the list, in the mobile view. it made the list noisy. may we have to switch off the plugin for the mobile view or may it not affect the mobile view?


(Angus McLeod) #224

Sorry could you clarify what you mean? Screenshots are good.


(Tobias Eigen) #225

FYI - the excerpt text is missing from most but not all the “Suggested Topics” below posts on both of my sites. This looks a bit wonky. :wink:

Great to see this plugin live on the Global Legal Empowerment Network - looks fabulous. Many thanks! :rocket:


(Angus McLeod) #226

Just made a little tweak that should ensure no excerpt text creeps into the suggested topics.


(Tobias Eigen) #227

looking good - thanks! :seedling:

I like that topic list previews is used on private messaging - I did notice however that the heart is displayed as red as though I already liked it, even if I have not yet clicked to like it. In the example below I have not liked any of these posts.

Would love to be able to unlike topics via the topic list preview, but you know that already. :heart_eyes_cat:


(Angus McLeod) #228

Indeed. Discourse has i.fa-heart styled to pink ($love) with an !important flag to ensure it is styled pink on the Summary, Notification and Activity pages. See here. This overrides my classes. I considered submitting a PR to change that, but then remembered that style change-only PRs aren’t the go.

So, I’ve added my own !important styles :slight_smile:


(Tobias Eigen) #229

confirmed working on my instance. nicely done. :tangerine:


(Tobias Eigen) #230

Probably out of scope but I found myself today wishing for other topic actions on the topic link preview, such as link, delete, edit, admin actions etc. In other words, not just having like and bookmark actions available but the post menu, the whole kit and kaboodle just as it looks under posts. I can imagine alot of people would find this useful for managing topics.


(Tobias Eigen) #231

Hey @angus I’m not sure when this happened but now when I update my discourse with topic list previews included it does not work on mobile. I see my custom menu across the top and a white screen, and an error in the log.

I’m still testing different combinations of plugins but putting topic list previews back in after removing them all definitely prevented it from running.

Uncaught TypeError: Cannot read property ‘length’ of undefined
Url: https://foo.bar/assets/application-7a5ad329e40f80ea6be2808582f91108224077e081248a90e9d61fa00c527524.js
Line: 67
Column: 4262
Window Location: https://foo.bar/

TypeError: Cannot read property ‘length’ of undefined
at p.reopen.d.value [as _mobileEdits] (https://foo.bar/assets/application-7a5ad329e40f80ea6be2808582f91108224077e081248a90e9d61fa00c527524.js:67:4262)
at Object.f [as sendEvent] (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:7:6312)
at new h (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:11:28678)
at Function.P.create (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:11:30894)
at r.Mixin.create.createChildView (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:13:2188)
at Object.o.default.appendChild (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:14:16500)
at r.Mixin.create.appendChild (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:13:1715)
at Object.i [as default] (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:5:25209)
at s (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:5:20941)
at t (https://foo.bar/assets/ember_jquery-9c4852b4384fc211bf22de79cc4f7c4188ac0e9465ae13a4d07873dfcd97fd51.js:5:27338)


(Pad Pors) #232

here the only avatar that is shown in the list is “R”, the shown numbers in the list are the number of new posts in the topics, and you can see the whole UI of mobile version is mixed! when i remove the preview plugin it resets to the original preview.


#233

Hi guys, I am testing the plugin and so far it works very well. One question: is it possible to show the thumbnails also on the front page or in the new/latest? So far thumbnails are shown only if a user clicks in the specific category.


#234

@kfk you have to enable the global setting for the plugin by going to Admin>Settings>Plugins and enabling the features you want (Thumbnail, Excerpt, etc) there. Right now I think you have it enabled only for the specific categories.


(Angus McLeod) #235

@tobiaseigen Should be fixed now. Sorry for the delay.


(Angus McLeod) #236

Please test this again with this commit.

It looks like it’s working normally on rtl arrangement:


Broken images on meta
(Angus McLeod) #237

hm does the image I attached to that post appear broken to everyone else as well?

edit: the image attached to this post appears broken too…

bug report: Broken images on meta


(Angus McLeod) #238

Hey, thanks for testing out this plugin. As @P16 mentioned, please try the ‘Universal’ settings in Admin > Settings > Plugins.


(Tom Newsom) #239

I have uninstalled this plugin because the rate of change is very high and stability does not seem to be settling down. Can I suggest a period of testing and bugfixing rather than responding to new feature requests?

The functionality is great btw, I just don’t feel like I can rely on it day-to-day.


#240

I think the dev is very helpful and patient while dealing with so many issues and requests everyday. I would suggest not updating the plugins until no issues are reported for a while or maybe setting up a local discourse for testing purposes?


(Tom Newsom) #241

Yes sorry that came over rather harsh. The effort is very much appreciated, I just think the enthusiasm might benefit from a slower release pace.


#242

Yep I know there have been a few issues recently, but i think that was because of some big new features and changes. Maybe now it will break a lot less since most of the issues have been sorted out.