토픽 목록 썸네일

[undasein (Andres Garrido)]

Thank you too, component and site running as expected

[david (David Taylor)]

I just merged a change in Discourse core which will significantly speed up the fetching of hotlinked images:

https://github.com/discourse/discourse/commit/bf6f8299a781922737fa01c408078f4c090885b6

For people using this theme component, that means that thumbnails for hotlinked images will be generated almost immediately, rather than the previous 10 minute delay

[merefield (Robert)]

Don’t tell me you read my posts? ;). Thanks very much for working on that!

David, I’m assuming that doesn’t require any config changes to the Theme Component code as I can’t see any related commits?

[david (David Taylor)]

Correct - no theme changes needed.

The core change is part of a wider refactoring of our ‘hotlinked image’ handling. The speed improvement for thumbnail-consuming-theme-components is a nice side effect!

[merefield (Robert)]

A massive win for the Discourse platform, thanks!

[bartv (Bart)]

I used to be able to add more than 5 tags in the settings, but I’m getting an error now:

[david (David Taylor)]

Thanks for the report @bartv - should be fixed by FIX: Ensure there is no limit on tag list settings (#17355) · discourse/discourse@fb31ae0 · GitHub

[Ivan_Rapekas]

@Ivan_Rapekas

Is any way not to upscale tiny images 30x30 etc

Probably there is a workaround, but it is applied to all images:

// Do not upscale thumbnails
.topic-thumbnails-list .topic-list-thumbnail .main-thumbnail, 
.topic-thumbnails-grid .topic-list-thumbnail .main-thumbnail, 
.topic-thumbnails-masonry .topic-list-thumbnail .main-thumbnail, 
.topic-thumbnails-minimal .topic-list-thumbnail .main-thumbnail {
	width: max-content;
	height: max-content;
}

[davidkingham]

In a recent build I started getting these horizontal lines behind the thumbnails, you can see them live on my site now https://community.naturephotographers.network/ I’ve tried removing all components except TLT and any CSS but they still remain, any ideas?

[david (David Taylor)]

@techAPJ / @Roman it looks like the recent changes in the discourse-adplugin are introducing a blank <tr> between every topic in the topic list. Can we use the shouldRender hook on the connector to make sure it’s only rendered if we’re actually displaying an ad there?

[Roman (Roman Rizzi)]

The ad slot render logic is a bit complex, so I’m not sure if it’s that easy. I’ll work on a fix!

[Roman (Roman Rizzi)]

Should be fixed by:

https://github.com/discourse/discourse-adplugin/pull/146

[davidkingham]

Thanks Roman, unfortunately the problem still exists for me. I only updated the plugin, does core need an update too?

[Bank_Live]

I thing is should select any images form all detail post. Sometimes the first image doesn’t convey what this thread is all about.

[Roman (Roman Rizzi)]

Sorry about that. Can you please try again now? I pushed another fix.

[davidkingham]

I believe that did it, thank you Roman!

[Bank_Live]

I use plugin pull rss can add images in detail more?

Thank you.

[Tara_Walton]

I’m not sure I understand how to change the placeholder icon.
@david Any help would be appreciated

[tshenry (Taylor)]

At the moment, the placeholder icon is limited to Font Awesome icons. You can find a list of available icons at Find the Perfect Icon for Your Project in Font Awesome 5 | Font Awesome. Adding them can be a little tricky depending on what you end up choosing. If you find an icon you like, go ahead and share it and I can help walk you through how to ensure it works.

The setting does not support custom images at this point. That would need to be filed as a feature request if that’s what you’re after.

[Tara_Walton]

Ah! That helped and I think I got it figured out. Added the one I wanted to svg icon subset and used the icon name (without the fa/far/fad part).
Looks great! Thank you so much!

If boss decides an image would be better, how do I submit a feature request for a component?