Topic notifications emails are not being sent if adding a Staff Colour to the post

zogstrip · February 11, 2026, 10:27am

Better late than never ?!

github.com/discourse/discourse

FIX: Send notification emails for staff-coloured posts (#37712)

main ← fix/staff-coloured-posts-email-notifications

merged 12:26PM - 11 Feb 26 UTC

ZogStriP

+24 -8

When a staff member applies "Staff Colour" to a post, it changes `post_type` fro…m `regular` (1) to `moderator_action` (2). The `NotificationEmailer` only sent emails for `regular` and `whisper` post types, so staff-coloured posts silently skipped email delivery. The same issue affected `PostAlerter`'s `@here` mention expansion which also filtered on post type. This is safe to fix because the only two places that needed updating are `NotificationEmailer::EMAILABLE_POST_TYPES` and `PostAlerter#expand_here_mention`. System-generated moderator posts (close/split/merge) never reach this code — `PostJobsEnqueuer` skips them via `skip_after_create?`, so they never generate the notification types that flow through `NotificationEmailer`. Similarly, system moderator posts don't contain `@here` mentions, so adding `moderator_action` to `expand_here_mention` is equally safe. https://meta.discourse.org/t/370857

Topic		Replies	Views
Can publishing "from" the `#staff` category prevent emails being sent? Support	0	55	February 1, 2025
Publication of Timed Topics don't trigger new topic notifications Bug	17	1758	June 29, 2020
No email notifications for posts that require approval Bug	9	1835	August 24, 2016
Make Staff Notice send a Mailing List email? Support post-notices	4	578	August 27, 2023
Notification email for all posts on topic to users who even aren't tracking the topic Support	4	941	September 9, 2016

Topic notifications emails are not being sent if adding a Staff Colour to the post

Related topics