# Turkish Translation needs some love **URL:** \ **Category:** Translations\ **Created:** [2017年二月8日 00:22 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101 "2017-02-08T00:22:11Z")\ **Posts on this page:** 14\ **Page:** 1
**Author:** ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)\ **Post date:** [2017年二月8日 00:22 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/1 "2017-02-08T00:22:11Z")
I’m reaching out on behalf of someone else who doesn’t have access to Meta anymore. I don’t recall the username, but on Sitepoint he goes by @ogsocials (his username on Meta was @o.g). In short, he is having issues with the Turkish translation and customizing site text. After digging into it tonight, the issue is quite clear, the Turkish Translations needs some love and other languages may be in the same situation. First let’s look at the request I received: “The reply button is in english and I’d like to customize it to Turkish” Seems simple enough, Customize Site Text should be sufficient, right? Well, not so fast. It ends up the Turkish translation does not have the appropriate keys for the Reply button. > As you can see, it has `reply` with sub-keys `title` and `help`. The English version is very different: > There is another layer of keys that does not exist in the Turkish language and as such, and I’ve confirmed on my sandbox, when in Turkish, you cannot customize these keys. They show up in a search, but the customization does not take. I imagine this is because the Turkish file itself does not have the appropriate structure so it continues to fallback to English, but I’m guessing here (as I’m not 100% well versed in translations). All I can say is I did the following to verify it is impossible to translate the post or topic reply buttons. 1. Set your default locale to Turkish 2. Go to Customize \> Site Text 3. Search for ‘Reply’ 4. Click on `js.topic.reply.post.title` 5. Customize the Text and Save it 6. Navigate to topic, refresh the page, text has not updated I have a feeling that Transfix needs to be updated first for this issue to resolve itself and permit users in the Turkish language to customize their site text, but again, I could be wrong here. Can anyone a bit more versed in Translations give this a quick lookover and verify what I’ve uncovered? ---
**Author:** ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)\ **Post date:** [2017年二月8日 00:25 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/2 "2017-02-08T00:25:54Z")
Looks like all languages in the format `xx_XX` are missing this keys, let me take a look. ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 00:40 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/3 "2017-02-08T00:40:38Z")
Wait, no, this was the erroneous community PR that got checked in, the bad translation that decided “hey we need to distinguish between reply-to-the-topic and reply-to-the-post”. Which was.. 💩 Reply should NOT be broken into these two fields. So the English translation file is the one that is wrong, probably an artifact of that _disastrous_ PR. ---
**Author:** ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)\ **Post date:** [2017年二月8日 00:42 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/4 "2017-02-08T00:42:37Z")
I have this PR that fixes this for locales with territory code: [https://github.com/discourse/discourse/pull/4695](https://github.com/discourse/discourse/pull/4695) Now English and most languages are right, rolling this back would be more work. ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 00:43 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/5 "2017-02-08T00:43:09Z")
I am sorry but your PR is incorrect. WE DO NOT WANT to distinguish this text. I will commit the code personally if I have to. English MUST be fixed. The other languages ARE correct. This is all fallout from that hideous community PR. ---
**Author:** ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)\ **Post date:** [2017年二月8日 00:46 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/6 "2017-02-08T00:46:14Z")
Other languages have this atrocity too > Based on this commit, it seems the broken out version was intended… [https://github.com/discourse/discourse/commit/a553fecb51150a127f7eee4ee1a3cf734f471157](https://github.com/discourse/discourse/commit/a553fecb51150a127f7eee4ee1a3cf734f471157) ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 00:47 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/7 "2017-02-08T00:47:30Z")
The breakage is here: [https://github.com/discourse/discourse/pull/4600/files](https://github.com/discourse/discourse/pull/4600/files) If that is what @zogstrip pulled forward, it was done incorrectly. I’ll do it myself if I have to. Such a dumb, dumb change in that PR – completely pointless and breaks every translation for a key button. ---
**Author:** ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)\ **Post date:** [2017年二月8日 00:49 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/8 "2017-02-08T00:49:39Z")
Ah, yeah, that is definitely related to the problem. ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 00:50 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/9 "2017-02-08T00:50:12Z")
Every part of that PR fills me with rage. Plus all the disastrous fallout to date. All right @cpradio can you check my work? [https://github.com/discourse/discourse/commit/7c9f8cb2458e15844383ee8436f5fefc52a3db14](https://github.com/discourse/discourse/commit/7c9f8cb2458e15844383ee8436f5fefc52a3db14) 👼 YAML ``` reply: title: 'Reply' help: 'begin composing a reply to this topic' ``` 👼 i18n string keys ``` topic.reply.title topic.reply.help ``` 👹 YAML ``` post: title: 'Svar' topic: title: 'Svar' help: 'begynd at skrive et svar til dette emne' ``` 👹 i18n string keys ``` topic.reply.post.title topic.reply.topic.title ``` ---
**Author:** ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)\ **Post date:** [2017年二月8日 01:37 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/10 "2017-02-08T01:37:01Z")
It looks legit. From what I can tell it seems to remove it entirely from all places. 👍 ---
**Author:** ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)\ **Post date:** [2017年二月8日 02:17 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/11 "2017-02-08T02:17:49Z")
Just ran it on my sandbox, the test works now. Customizable in Turkish and all! Thanks! ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 02:57 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/12 "2017-02-08T02:57:41Z")
---
**Author:** ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)\ **Post date:** [2017年二月8日 09:04 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/13 "2017-02-08T09:04:43Z")
Me right now 😒 ![](https://global.discourse-cdn.com/meta/original/3X/a/4/a4e5a7693cd55e458ac8e191723ba0d3a2a49e5c.gif) ---
**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\ **Post date:** [2017年二月8日 09:19 UTC](https://meta.discourse.org/t/turkish-translation-needs-some-love/57101/14 "2017-02-08T09:19:34Z")
It was a weird PR, I only blame you a little tiny bit.