'
```
---
### Author:  [@david](https://meta.discourse.org/u/david)
#### Post date: [August 10, 2023, 2:43pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/2 "2023-08-10T14:43:25Z")
A manual rebuild should completely fix things, and the `/upgrade` page should become available again.
Are you running a [standard install](https://meta.discourse.org/t/142537?silent=true)? Can you let us know what plugin’s you have installed?
---
### Author:  [@kdambekalns](https://meta.discourse.org/u/kdambekalns)
#### Post date: [August 10, 2023, 3:26pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/3 "2023-08-10T15:26:56Z")
[Standard install](https://meta.discourse.org/t/142537?silent=true), but I admit the site is running since 2018 IIRC, so… but at least it’s docker-based and feels like a standard setup. As I said, so far everything worked as expected.
Plugins:
I rebuilt again, fixed the permissions and ran a few `git config --global --add safe.directory …` commands, but the `/upgrade` page is still showing an error and the log says:
```plaintext
NoMethodError (undefined method `sub!' for nil:NilClass)
app/controllers/application_controller.rb:420:in `block in with_resolved_locale'
app/controllers/application_controller.rb:420:in `with_resolved_locale'
lib/middleware/omniauth_bypass_middleware.rb:74:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:389:in `call'
lib/middleware/gtm_script_nonce_injector.rb:10:in `call'
config/initializers/100-quiet_logger.rb:20:in `call'
config/initializers/100-silence_logger.rb:29:in `call'
lib/middleware/enforce_hostname.rb:24:in `call'
lib/middleware/request_tracker.rb:228:in `call'
```
---
### Author:  [@david](https://meta.discourse.org/u/david)
#### Post date: [August 10, 2023, 4:26pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/4 "2023-08-10T16:26:01Z")
Please could you try running these commands
```plaintext
./launcher enter app
cd /var/www/discourse/plugins
su discourse
for d in *; do echo "$d: $(git -C $d config --get remote.origin.url)"; done
```
Every plugin should have a remote URL shown in the list. I suspect, based on the error, that one of them doesn’t 🤔
Expected output is something like
```plaintext
chat: https://github.com/discourse/discourse.git
discourse-automation: https://github.com/discourse/discourse-automation
discourse-chat-integration: https://github.com/discourse/discourse-chat-integration.git
...
```
---
### Author:  [@kdambekalns](https://meta.discourse.org/u/kdambekalns)
#### Post date: [August 10, 2023, 7:55pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/5 "2023-08-10T19:55:33Z")
Hu, _none_ of the plugins has a remote URL:
```plaintext
discourse@ocean-app:/var/www/discourse/plugins$ for d in *; do echo "$d: $(git -C $d config --get remote.origin.url)"; done
chat:
discourse-chat-integration:
discourse-details:
discourse-lazy-videos:
discourse-local-dates:
discourse-narrative-bot:
discourse-presence:
discourse-solved:
docker_manager:
plugins:
poll:
styleguide:
```
Interesting… actually, none of the directories even has a `.git` folder.
---
### Author:  [@kdambekalns](https://meta.discourse.org/u/kdambekalns)
#### Post date: [August 10, 2023, 8:11pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/6 "2023-08-10T20:11:33Z")
Digging further, the way we installed the plugins lacked the part `sudo -E -u discourse` on the `git clone …` calls in `containers/app.yml`. Then again, the existing `docker_manager` line did never have this.
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [August 10, 2023, 10:23pm UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/7 "2023-08-10T22:23:56Z")
> [@kdambekalns](#):
>
> Digging further, the way we installed the plugins lacked the part `sudo -E -u discourse` on the `git clone …` calls in `containers/app.yml`.
I don’t think that’s the problem.
> [@kdambekalns](#):
>
> Then again, the existing `docker_manager` line did never have this.
I think I suggested that they change the examples when they started suggesting to do that, but it didn’t get any attention.
I still don’t do that, but think I might start, as it might keep git from complaining.
---
### Author:  [@david](https://meta.discourse.org/u/david)
#### Post date: [August 11, 2023, 7:34am UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/8 "2023-08-11T07:34:26Z")
> [@kdambekalns](#):
>
> Interesting… actually, none of the directories even has a `.git` folder.
Huh! That is very strange, and would definitely explain the error. It looks like even Discourse core’s `.git` is missing (since `chat`/`poll`/etc. don’t have a URL).
Can you share the snippet of `app.yml` where the plugins are installed?
This is also a little weird:
> [@kdambekalns](#):
>
> ```plaintext
> plugins:
>
> ```
It suggests you have a plugins directory **inside** your plugins directory 🤔
---
### Author:  [@Ed\_S](https://meta.discourse.org/u/Ed_S)
#### Post date: [August 11, 2023, 7:39am UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/9 "2023-08-11T07:39:49Z")
Sometimes when people find that there is no .git subdirectory, it’s because someone made a simple copy from one place to another, and the copy missed out the dotfiles. This would never happen with a standard installation, but could happen where there is a bit of history of people doing things which they believe they understand. (Which I mean in a nice way, but it can cause mistakes.)
---
### Author:  [@kdambekalns](https://meta.discourse.org/u/kdambekalns)
#### Post date: [August 16, 2023, 9:36am UTC](https://meta.discourse.org/t/undefined-method-sub-when-visiting-admin-upgrade/274682/10 "2023-08-16T09:36:41Z")
This is how the plugins are installed from `app.yml`
```plaintext
hooks:
after_code:
- exec:
cd: $home/plugins
cmd:
- git clone https://github.com/discourse/docker_manager.git
- git clone https://github.com/discourse/discourse-solved.git
- git clone https://github.com/discourse/discourse-chat-integration.git
```
There was an extra `mkdir plugins` as the first command, that’s why the (empty) `plugins` folder existed. I removed that leftover from the past years…
The folder for the packages installed as per the `app.yml` above all have a `.git` foler inside.
Coming back to listing the remote URLs… as `discourse` user:
```plaintext
discourse@ocean-app:/var/www/discourse/plugins$ for d in *; do echo "$d: $(git -C $d config --get remote.origin.url)"; done
chat:
discourse-chat-integration: https://github.com/discourse/discourse-chat-integration.git
discourse-details:
discourse-lazy-videos:
discourse-local-dates:
discourse-narrative-bot:
discourse-presence:
discourse-solved: https://github.com/discourse/discourse-solved.git
docker_manager: https://github.com/discourse/docker_manager.git
poll:
styleguide:
```
As `root` user:
```plaintext
root@ocean-app:/var/www/discourse/plugins# for d in *; do echo "$d: $(git -C $d config --get remote.origin.url)"; done
chat: https://github.com/discourse/discourse.git
discourse-chat-integration:
discourse-details: https://github.com/discourse/discourse.git
discourse-lazy-videos: https://github.com/discourse/discourse.git
discourse-local-dates: https://github.com/discourse/discourse.git
discourse-narrative-bot: https://github.com/discourse/discourse.git
discourse-presence: https://github.com/discourse/discourse.git
discourse-solved:
docker_manager: https://github.com/discourse/docker_manager.git
poll: https://github.com/discourse/discourse.git
styleguide: https://github.com/discourse/discourse.git
```
My guess: permissions are totally borked. Is this looking correct (inside the container)?
```plaintext
root@ocean-app:/var/www/discourse# ls -la
total 508
drwxr-xr-x 1 root root 4096 Aug 10 15:38 .
drwxr-xr-x 1 root root 4096 Jul 11 00:33 ..
drwxr-xr-x 1 root root 4096 Jul 11 00:34 app
drwxr-xr-x 1 root root 4096 Aug 10 14:36 bin
-rw-r--r-- 1 root root 316 Aug 10 14:36 Brewfile
drwxr-xr-x 1 root root 4096 Jul 11 00:34 .bundle
drwxr-xr-x 1 root root 4096 Aug 10 14:47 config
-rw-r--r-- 1 root root 304 Aug 10 14:36 config.ru
-rw-r--r-- 1 root root 1303 Aug 10 14:36 CONTRIBUTING.md
-rw-r--r-- 1 root root 2347 Aug 10 14:36 COPYRIGHT.md
lrwxrwxrwx 1 root root 10 Aug 10 14:36 d -> bin/docker
drwxr-xr-x 1 root root 4096 Aug 10 14:36 db
drwxr-xr-x 1 root root 4096 Aug 10 14:36 .devcontainer
-rw-r--r-- 1 root root 1315 Aug 10 14:36 discourse.sublime-project
drwxr-xr-x 1 root root 4096 Aug 10 14:36 docs
drwxr-xr-x 1 root root 4096 Aug 10 14:36 documentation
-rw-r--r-- 1 root root 305 Aug 10 14:36 .editorconfig
-rw-r--r-- 1 root root 334 Aug 10 14:36 .eslintignore
-rw-r--r-- 1 root root 1061 Aug 10 14:36 .eslintrc
-rw-r--r-- 1 root root 7146 Aug 10 14:36 Gemfile
-rw-r--r-- 1 root root 15678 Aug 10 14:36 Gemfile.lock
drwxr-xr-x 1 root root 4096 Aug 10 14:36 .git
-rw-r--r-- 1 root root 852 Aug 10 14:36 .gitattributes
-rw-r--r-- 1 root root 2205 Aug 10 14:36 .git-blame-ignore-revs
-rw-r--r-- 1 root root 272 Aug 10 15:38 .gitconfig
drwxr-xr-x 1 root root 4096 Aug 10 14:36 .github
-rw-r--r-- 1 root root 1282 Aug 10 14:36 .gitignore
drwxr-xr-x 1 root root 4096 Aug 10 14:36 images
-rw-r--r-- 1 root root 279 Aug 10 14:36 jsconfig.base.json
-rw-r--r-- 1 root root 432 Aug 10 14:36 .jsdoc
-rw-r--r-- 1 root root 1937 Aug 10 14:36 lefthook.yml
drwxr-xr-x 1 root root 12288 Aug 10 14:36 lib
-rw-r--r-- 1 root root 1470 Aug 10 14:36 .licensed.yml
-rw-r--r-- 1 root root 375 Aug 10 14:36 .licensee.json
-rw-r--r-- 1 root root 18092 Aug 10 14:36 LICENSE.txt
drwxr-xr-x 1 root root 4096 Aug 10 14:36 log
drwxr-xr-x 1 root root 20480 Aug 10 14:37 node_modules
-rw-r--r-- 1 root root 21 Aug 10 14:36 .npmrc
-rw-r--r-- 1 root root 3114 Aug 10 14:36 package.json
drwxr-xr-x 1 discourse discourse 4096 Aug 16 08:44 plugins
-rw-r--r-- 1 root root 728 Aug 10 14:36 .prettierignore
-rw-r--r-- 1 root root 283 Aug 10 14:36 .prettierrc
drwxr-xr-x 1 root root 4096 Aug 14 00:42 public
-rwxr-xr-x 1 root root 305 Aug 10 14:36 Rakefile
-rw-r--r-- 1 root root 6753 Aug 10 14:36 README.md
-rw-r--r-- 1 root root 25 Aug 10 14:36 .rspec
-rw-r--r-- 1 root root 246 Aug 10 14:36 .rspec_parallel
-rw-r--r-- 1 root root 290 Aug 10 14:36 .rubocop.yml
-rw-r--r-- 1 root root 10 Aug 10 14:36 .ruby-gemset.sample
-rw-r--r-- 1 root root 6 Aug 10 14:36 .ruby-version.sample
drwxr-xr-x 1 root root 4096 Aug 10 14:36 script
drwxr-xr-x 1 root root 4096 Aug 10 14:36 spec
-rw-r--r-- 1 root root 66 Aug 10 14:36 .streerc
-rw-r--r-- 1 root root 1054 Aug 10 14:36 .template-lintrc.js
drwxr-xr-x 1 root root 4096 Aug 10 14:36 test
drwxr-xrwx 1 discourse discourse 4096 Aug 10 15:16 tmp
-rw-r--r-- 1 root root 2575 Aug 10 14:36 translator.yml
drwxr-xr-x 1 root root 4096 Jul 11 00:34 vendor
drwxr-xr-x 1 root root 4096 Aug 10 14:36 .vscode-sample
-rw-r--r-- 1 root root 204458 Aug 10 14:36 yarn.lock
```
What is the expected ownership/permissions setup?