# Comprendere i link di confronto GitHub sulla pagina di aggiornamento
**URL:** https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047
**Category:** Support
**Created:** [25 Dicembre 2018, 11:37pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047 "2018-12-25T23:37:50Z")
**Posts on this page:** 18
**Page:** 1
### Author:  [@abrambailey](https://meta.discourse.org/u/abrambailey)
#### Post date: [25 Dicembre 2018, 11:37pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/1 "2018-12-25T23:37:50Z")
Something that has bugged me for a little while, but which I have not mentioned until now, is that the links provided on the upgrade screen don’t allow for easy comparison of the currently-installed commit vs the new-version commit.
In the image above, the first link goes here:
`https://github.com/discourse/discourse/compare/efcea14...tests-passed`
And the second link goes here:
`https://github.com/discourse/discourse/compare/69aa8f1...tests-passed`
My suggestion is also generating a link to the comparison of those two commits, like: [Comparing efcea14...69aa8f1 · discourse/discourse · GitHub](https://github.com/discourse/discourse/compare/efcea14...69aa8f1)
---
### Author:  [@abrambailey](https://meta.discourse.org/u/abrambailey)
#### Post date: [25 Dicembre 2018, 11:39pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/2 "2018-12-25T23:39:16Z")
I just realized the first link and my suggested link are essentially identical. Would this always been the case, even if I get behind by more than one version?
---
### Author:  [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [25 Dicembre 2018, 11:55pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/3 "2018-12-25T23:55:24Z")
Yes, the first link is your current commit compared to the head of `tests-passed`, which is what your upgrade will be. Never fully understood what the second link is for myself…
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 Dicembre 2018, 12:10am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/4 "2018-12-26T00:10:42Z")
> [@abrambailey](#):
>
> I just realized the first link and my suggested link are essentially identical.
You already have exactly what you’re asking for.
The other version comparsion is comparing the tests passed label to the latest checkin at `discourse/discourse`, thus **the only way that would be different is if someone just checked in something that causes the tests to fail**.
Furthermore, the only way it would _remain_ different is if the build was not fixed for an extended period of time, meaning more and more stuff was checked into latest and _none_ of it fixed the build by getting the tests to pass. This is rare, but it does happen from time to time.
It is a valid comparison, in my opinion.
So there’s nothing to do here, I don’t think either of these requests are actionable? Shall I close this topic @abrambailey?
---
### Author:  [@abrambailey](https://meta.discourse.org/u/abrambailey)
#### Post date: [26 Dicembre 2018, 12:27am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/6 "2018-12-26T00:27:30Z")
Sorry just re-read what @jomaxro said, and he answered my question. Thanks, yes you can close this.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 Dicembre 2018, 12:35am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/7 "2018-12-26T00:35:55Z")
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [26 Dicembre 2018, 12:36am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/8 "2018-12-26T00:36:24Z")
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [26 Dicembre 2018, 12:37am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/9 "2018-12-26T00:37:51Z")
Sorry, this is broken now, I noticed it today
We are comparing something nonsensical here, the intention was to show the difference between my current commit and the commit I will be upgrading to
In practice we show nonsense for the second link, hence it should not be a link
Or the reverse … something has to give… but linking to:
[https://github.com/discourse/discourse/compare/69aa8f1...tests-passed](https://github.com/discourse/discourse/compare/69aa8f1...tests-passed) when I am 490 commits behind is bananas, especially when the upgrade button is below the link
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 Dicembre 2018, 12:46am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/11 "2018-12-26T00:46:08Z")
Wait… what do you mean? It’s 100% valid on my colocated Discourse install.
The version of Discourse per the meta tag in view source:
``
the dashboard upgrade reports the currently installed **local version** of Discourse as
`discourse (7b253db)`
which is completely consistent with the version number in the meta tag above ↑ and the **remote version** is reported as
`Remote Version: 69aa8f1`
which is consistent with the latest checkin at `https://github.com/discourse/discourse/commits/master` ↓ ↓
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [26 Dicembre 2018, 12:52am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/12 "2018-12-26T00:52:38Z")
It is acting “correctly”, it is just mega super confusing. I hit it today when upgrading reviews and just assumed there was some bug.
Or maybe … most simple thing is NOT to link commit hashes anymore and instead only hyperlink the words “490 new commits”
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 Dicembre 2018, 12:54am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/13 "2018-12-26T00:54:34Z")
Oh I see what you’re saying. The links should be swapped, so the upgrade button is closer to the “exactly how many changes will I get and what will they be” link.
That’s kind of a different argument, but OK, sure.
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [26 Dicembre 2018, 8:34am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/14 "2018-12-26T08:34:04Z")
This is now complete and wonderful. Significantly less confusing.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [26 Dicembre 2018, 8:41am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/15 "2018-12-26T08:41:04Z")
I would suggest the repository on the left linking to the public github repo though 😉
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [26 Dicembre 2018, 8:43am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/16 "2018-12-26T08:43:48Z")
Sure … @Osama when you do the ember upgrade can you take that? Also, the styling on the commit hashes is too strong should be lighter grey, plus… maybe we should try for friendlier names if available: `v2.2.0.beta6 +100` and so on… not possible for all repos, but where it is … it would be very handy.
---
### Author:  [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [27 Dicembre 2018, 10:55pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/18 "2018-12-27T22:55:39Z")
Really like the visual change @sam, so much clearer.
However, it looks like we switched from 3-dot diff to a 2-dot diff, was that intentional? I personally much prefer being able to review the list of commit messages ([Comparing 7e1f20b...1d62d3d · discourse/discourse · GitHub](https://github.com/discourse/discourse/compare/7e1f20b...1d62d3d)) rather than simply seeing the changes made ([Comparing 7e1f20b..1d62d3d · discourse/discourse · GitHub](https://github.com/discourse/discourse/compare/7e1f20b..1d62d3d)).
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [28 Dicembre 2018, 6:17am UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/19 "2018-12-28T06:17:45Z")
Sure, @osama can change that when he gets around to updating … I did not make that particular change on-purpose
---
### Author:  [@Osama](https://meta.discourse.org/u/Osama)
#### Post date: [26 Gennaio 2019, 7:53pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/20 "2019-01-26T19:53:11Z")
This was completed ~3 weeks ago, I forgot to update here 😅
---
### Author:  [@Osama](https://meta.discourse.org/u/Osama)
#### Post date: [29 Gennaio 2019, 3:00pm UTC](https://meta.discourse.org/t/understanding-the-github-comparison-links-on-the-upgrade-page/105047/21 "2019-01-29T15:00:03Z")
This topic was automatically closed after 2 days. New replies are no longer allowed.