Unexpected error notification sent when uploading backup to S3 failed

pr-welcome

(Erick Guan) #1

I didn’t test it but it’s reported in Chinese here. This should be an easy bug to fix.

When user commence the backup procedure manually in the admin panel, the backup operation succeed but uploading to S3 failed due to network issue. Discourse send unexpected notification claimed the backup is failed.

Discourse version reported is 1.9.4, v2.0.0.beta9.

The error should be due to an escaped network exception.


(Régis Hanol) #2

Does that error still happen on latest?


(Erick Guan) #3

I can’t confirm now but I think so since we didn’t catch a possible exception. discourse/backuper.rb at master · discourse/discourse · GitHub

Relevant doc:
https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/S3/MultipartUploadPart.html#upload-instance_method

Would you mind marking this as a trivial task?