Unresponsive script on /admin/users/USER/badges


(PJH) #1

Going to a particular /admin/users/USER/badges

In this instance I got the dialog 3 times before the page was usable.

This particular user had 6280 badges listed, but I get this problem with a few users.


#2

I haven’t gotten this on chrome (pretty beefy machine, however: i7-4770 CPU 4 core @ 3.40GHz, 24GB RAM), BTW. However, I will say that chrome’s task manager says that tab went from ~500MB to ~1GB when looking at that user’s badge page.

It came up in FF, although the spinner stopped while it was loading.

Either browser pegs a core for ~10s (


(Jeff Atwood) #4

I assume you are using a 64-bit browser? I recommend it!


#6

Yes, both that I used were 64-bit.


(Sam Saffron) #7

This is essentially the “John Skeet” problem

All of the time is in Ember rendering the list, and the list is using none of the fancy new techniques so its slow.

Trivial fix is to limit it to render only say 30 rows and pull in more rows as you go. We need all the badges there cause you may want to revoke.


#8

But not necessarily immediately. Lots of filtering opportunities here.

Maybe you show a distinct entry for each type of badge, and then drill down if you need to. This would eliminate @PJH’s problem.


(Sam Saffron) #10

Perf should be much better post

https://github.com/discourse/discourse/commit/fe578f9944679b36f81a6b9df8214b8ea5a4151f

It does a lot of the work client side so I imagine that at 100k badges we may meet another bottleneck

Closing for now, flag to reopen if you do not feel it is resolved.


(Sam Saffron) #11