# Unsolving a topic does not remove autoclose

**URL:** https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907
**Category:** Support
**Tags:** solved
**Created:** [August 16, 2018, 6:05pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907 "2018-08-16T18:05:56Z")
**Posts on this page:** 13
**Page:** 1

<div class="post-metadata">

### Author: ![tmomas](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tmomas/32/109144_2.png) [@tmomas](https://meta.discourse.org/u/tmomas)
#### Post date: [August 16, 2018, 6:05pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/1 "2018-08-16T18:05:56Z")

</div>

Shortly after installation of the solved plugin we noticed some topics having the autoclose message " This topic will close 7 days after the last reply." at the bottom, but there was no posting marked as the solution.

We now got a [confirmed case of setting the solved status inadvertently](https://forum.openwrt.org/t/luci-openwrt-18-06-on-tp-link-wr1043nd-v1-x-as-access-point/19154/5?u=tmomas), where the unsolving of the topic did remove the solved status, but left the autoclose in place.

Can you please look into this and make the solved plugin remove the autoclose if the topic is unsolved again?

---

<div class="post-metadata">

### Author: ![eduperez](https://avatars.discourse-cdn.com/v4/letter/e/e9a140/32.png) [@eduperez](https://meta.discourse.org/u/eduperez)
#### Post date: [August 16, 2018, 8:29pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/2 "2018-08-16T20:29:53Z")

</div>

This thread was closed after 7 days after the last reply, even if I did not press the “solved” button at all:

> **[Pre-compiled updated mwlwifi drivers for stable releases](https://forum.openwrt.org/t/pre-compiled-updated-mwlwifi-drivers-for-stable-releases/3262/)**
>
> I have decide to start following Linksys' official repo for the mwlwifi drivers at https://github.com/kaloz/mwlwifi, and make pre-compiled packages, that can be installed on top of stable releases, so more people can test the latest version,...

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [August 16, 2018, 10:57pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/3 "2018-08-16T22:57:09Z")

</div>

Sure I support a change that removes the close timer

- IF it was placed on the topic by the solved plugin (and not a staff member)
- IF the topic is unsolved

---

<div class="post-metadata">

### Author: ![Bolarinwa\_Balogun](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/bolarinwa_balogun/32/138753_2.png) [@Bolarinwa\_Balogun](https://meta.discourse.org/u/Bolarinwa_Balogun)
#### Post date: [August 24, 2018, 9:23pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/4 "2018-08-24T21:23:56Z")

</div>

Regarding the change, Is it safe to assume that if the user that set the timer is nil, then the timer was set by solved?

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [August 24, 2018, 10:44pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/5 "2018-08-24T22:44:05Z")

</div>

Not sure, we probably need a different unique marker

---

<div class="post-metadata">

### Author: ![Bolarinwa\_Balogun](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/bolarinwa_balogun/32/138753_2.png) [@Bolarinwa\_Balogun](https://meta.discourse.org/u/Bolarinwa_Balogun)
#### Post date: [August 24, 2018, 11:43pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/6 "2018-08-24T23:43:01Z")

</div>

What would you suggest? I’m assuming the unique marker would have to be an object

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [August 26, 2018, 11:19pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/7 "2018-08-26T23:19:52Z")

</div>

This API in core needs to be extended to add a reason.

> <https://github.com/discourse/discourse-solved/blob/main/plugin.rb#L109-L113>

I think PR welcome here is not really going to work, going to hand this over to @tgxworld

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [August 31, 2018, 4:13am UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/9 "2018-08-31T04:13:55Z")

</div>

> [@eduperez](#):
>
> This thread was closed after 7 days after the last reply, even if I did not press the “solved” button at all:

Are you able to reproduce this? The solved plugin will only add the topic timer if the “solved” button was clicked and `SiteSetting.solved_topics_auto_close_hours` is enabled. I think something else it at play here for your instance. Perhaps you have auto close configured for the category?

> [@sam](#):
>
> This API in core needs to be extended to add a reason.

I’m thinking of storing the topic timer id in the topic’s custom fields instead and avoid having to add an additional column that is only used by the solved plugin when `SiteSetting.solved_topics_auto_close_hours` is enabled.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [August 31, 2018, 4:17am UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/10 "2018-08-31T04:17:44Z")

</div>

> [@tgxworld](#):
>
> I’m thinking of storing the topic timer id in the topic’s custom fields instead and avoid having to add an additional column that is only used by the solved plugin when

It is ok with me, your call, the topic timer table is pretty tiny so its not really a storage concern there.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [August 31, 2018, 4:22am UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/11 "2018-08-31T04:22:00Z")

</div>

Done in

[https://github.com/discourse/discourse-solved/commit/46258a5b11aff8a3583e1e228e8c9bc835a469c5](https://github.com/discourse/discourse-solved/commit/46258a5b11aff8a3583e1e228e8c9bc835a469c5)

🙂

---

<div class="post-metadata">

### Author: ![eduperez](https://avatars.discourse-cdn.com/v4/letter/e/e9a140/32.png) [@eduperez](https://meta.discourse.org/u/eduperez)
#### Post date: [September 2, 2018, 8:53pm UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/12 "2018-09-02T20:53:01Z")

</div>

> [@tgxworld](#):
>
> Are you able to reproduce this? The solved plugin will only add the topic timer if the “solved” button was clicked and `SiteSetting.solved_topics_auto_close_hours` is enabled. I think something else it at play here for your instance. Perhaps you have auto close configured for the category?

The issue happened when the topic self-closed after 7 days of inactivity, even when I did not click the “solved” button; I am not sure how can I reproduce it.

---

<div class="post-metadata">

### Author: ![tmomas](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tmomas/32/109144_2.png) [@tmomas](https://meta.discourse.org/u/tmomas)
#### Post date: [September 3, 2018, 12:20am UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/13 "2018-09-03T00:20:04Z")

</div>

Since it is impossible to trace back how that topic got its autoclose status: Can we please keep this out of this topic?

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [September 4, 2018, 10:00am UTC](https://meta.discourse.org/t/unsolving-a-topic-does-not-remove-autoclose/94907/14 "2018-09-04T10:00:11Z")

</div>

This topic was automatically closed after 32 hours. New replies are no longer allowed.
