I’m now on the latest commit level (105634435f). I upgrade Discourse about every week or so. Usually there are no issues at all. But now multiple theme components failed to load. With fail to load I mean the components do not show up anymore. The log feature in the admin panel does not show anything…

In addition, non-strict Javascript variable definitions like: xxx = 330; instead of var xxx = 330; will lead to JS “undefined variable” errors. We had to change all these in our scripts.

Yes, there is an issue with some theme components, we are working on a fix.

@pmusaraj thank you so much. Good luck

Do you know why errors are thrown for non-strict defined JS variables in components? Is this a post-processing error? Did anything change here?

The change that caused this problems was reverted an hour ago, please update to latest if your site was affected.

To add to what Falco said, the change will be added back in the next few days, but before I add it back I’ll make sure all our official themes/components are compatible with the change. So if you start seeing the problem with official themes/components again, updating them should fix the problem. I…

[圖片] Osama: I’ll also make a post to explain how to make themes/components compatible for people who have custom/private components on their sites. one of our themes (a banner theme) has been completely overwritten to its initial format and all of the changes we had made, has gone. there was …

Hmm that’s really weird. Have you updated your instance again to include Revert "FEATURE: Introduce theme/component QUnit tests (#12517)" (#12… · discourse/discourse@2b9ab3a · GitHub ? Can you elaborate a little more on what you mean by ‘initial format’? Do you mean you had local changes to the JS/CS…

Does this also explain the problem with JS variable definitions? If so, how?

I don’t think this issue has to do with this reverted feature, I had the same case with a component a few weeks ago, probably around the fork indicator feature (which concern plugins so :roll_eyes: probably irrelevant too, but I just had to fork the component to modify things).

Discourse 主题组件 `'use strict'` 变更预告 - 升级后主题将失效 - #19，作者：Osama - 支持

話題		回覆	觀看	活動
Upcoming core changes that may break some themes/components (April 12) Announcements	5	2810	2021年四月12日
If you want to edit this theme, out of luck? Support	1	538	2021年六月13日
Blank website after update Support	14	1782	2020年八月26日
Theme component update issue Development	7	338	2024年六月7日
One of your themes or plugins needs updating for compatibility with upcoming Discourse core changes Development	2	279	2024年七月6日