Upgrade to Beta8 deletes all icons

Nobody has intentionally deleted the logos! How do I check the log?

You can check it at https://members.webarchitects.coop/admin/logs/staff_action_logs

1 Like

Oh, I see, I started manually adding the logos earlier today when you said this this behaviour was a feature not a bug, then when it appears that perhaps it was a bug after all I removed them in order that the bug could be illustrated, sorry.

Here is a screenshot of what happened today, I’m afraid I don’t have another Discourse server to demonstrate this issue on other than a clients production server and I don’t really want to mess with it for this purpose.

As I said:

If the above isn’t of use in demonstrating this issue I’ll manually add the logos to this server and then upgrade it.

I have the permission of a client to illustrate the issue using their site:

https://sands.community/

As you can see this site has a logo:

And these are the settings:

[1] pry(main)> SiteSetting.where(name: "logo_url").first
=> #<SiteSetting:0x0000563235107e68
 id: 46,
 name: "logo_url",
 data_type: 1,
 value: "/public-images/sands-logo-text.png",
 created_at: Mon, 16 Oct 2017 18:22:28 UTC +00:00,
 updated_at: Mon, 30 Oct 2017 17:26:15 UTC +00:00>
[3] pry(main)> SiteSetting.where(name: "logo_small_url").first
=> #<SiteSetting:0x000056322e98d170
 id: 47,
 name: "logo_small_url",
 data_type: 1,
 value: "/public-images/sands-logo.png",
 created_at: Mon, 16 Oct 2017 18:22:56 UTC +00:00,
 updated_at: Mon, 30 Oct 2017 17:26:13 UTC +00:00>
[4] pry(main)> SiteSetting.where(name: "logo").first
=> nil
[6] pry(main)> OnceoffLog.exists?(job_name: "MigrateUrlSiteSettings")
=> true

In the admin interface we have a prompt to upgrade:

And in the settings there are no logos listed:

I hope this illustrates that there is an issue here? Please let me know if further details are needed.

1 Like

Very sorry to be using another account to post to this thread but I hit the max three posts in a row rule.

On the test version of the same clients server:

https://test.sands.community/

Discourse has been upgraded to v2.2.0.beta8 +27 and I also did a git pull and ./launcher rebuild app, git status reports Your branch is up-to-date with 'origin/master' and I also re-uploaded all the missing images using the admin interface:

However with mobile browsers, (or Chromium with a narrow width) there is a missing icon:

The URL for this image that Discourse uses is https://test.sands.community/uploads/default/original/2X/b/b7fa961032f8ae8c446574dbf9e4c53edc71f903.png and it is a 404.

These are the settings I could find in the rails console:

[1] pry(main)> SiteSetting.where(name: "logo_url").first
=> nil
[2] pry(main)> SiteSetting.where(name: "logo_small_url").first
=> nil
[3] pry(main)> SiteSetting.where(name: "logo").first
=> #<SiteSetting:0x000055a60fcf4710
 id: 177,
 name: "logo",
 data_type: 18,
 value: "3034",
 created_at: Tue, 15 Jan 2019 13:39:32 UTC +00:00,
 updated_at: Wed, 16 Jan 2019 12:04:33 UTC +00:00>
[4] pry(main)> SiteSetting.where(name: "logo_small").first
=> #<SiteSetting:0x000055a61007f998
 id: 176,
 name: "logo_small",
 data_type: 18,
 value: "3035",
 created_at: Tue, 15 Jan 2019 13:39:31 UTC +00:00,
 updated_at: Wed, 16 Jan 2019 12:04:32 UTC +00:00>
[8] pry(main)> SiteSetting.where(name: "digest_logo").first
=> #<SiteSetting:0x000055a61028c9c0
 id: 175,
 name: "digest_logo",
 data_type: 18,
 value: "2792",
 created_at: Tue, 15 Jan 2019 13:39:30 UTC +00:00,
 updated_at: Tue, 15 Jan 2019 13:39:30 UTC +00:00>
[9] pry(main)> SiteSetting.where(name: "mobile_logo").first
=> #<SiteSetting:0x000055a610717940
 id: 180,
 name: "mobile_logo",
 data_type: 18,
 value: "3034",
 created_at: Wed, 16 Jan 2019 10:51:22 UTC +00:00,
 updated_at: Wed, 16 Jan 2019 12:04:32 UTC +00:00>
[10] pry(main)> SiteSetting.where(name: "large_icon").first
=> #<SiteSetting:0x000055a615d77970
 id: 170,
 name: "large_icon",
 data_type: 18,
 value: "3036",
 created_at: Tue, 15 Jan 2019 13:34:50 UTC +00:00,
 updated_at: Wed, 16 Jan 2019 12:26:59 UTC +00:00>
[11] pry(main)> SiteSetting.where(name: "favicon").first
=> #<SiteSetting:0x000055a616068e40
 id: 174,
 name: "favicon",
 data_type: 18,
 value: "3031",
 created_at: Tue, 15 Jan 2019 13:39:16 UTC +00:00,
 updated_at: Tue, 15 Jan 2019 13:39:16 UTC +00:00>
[12] pry(main)> SiteSetting.where(name: "apple_touch_icon").first
=> #<SiteSetting:0x000055a61652af50
 id: 173,
 name: "apple_touch_icon",
 data_type: 18,
 value: "3032",
 created_at: Tue, 15 Jan 2019 13:39:16 UTC +00:00,
 updated_at: Tue, 15 Jan 2019 13:39:16 UTC +00:00>
[13] pry(main)> SiteSetting.where(name: "opengraph_image").first
=> #<SiteSetting:0x000055a616696650
 id: 172,
 name: "opengraph_image",
 data_type: 18,
 value: "3033",
 created_at: Tue, 15 Jan 2019 13:39:15 UTC +00:00,
 updated_at: Tue, 15 Jan 2019 13:39:15 UTC +00:00>
[14] pry(main)> SiteSetting.where(name: "twitter_summary_large_image").first
=> #<SiteSetting:0x000055a6167dd540
 id: 171,
 name: "twitter_summary_large_image",
 data_type: 18,
 value: "3033",
 created_at: Tue, 15 Jan 2019 13:39:15 UTC +00:00,
 updated_at: Tue, 15 Jan 2019 13:39:15 UTC +00:00>

Any suggestion for settings I could look at or things I could do to solve the mobile image 404? I’m not going to touch their production server until I’m confident that all the icon issues have been resolved on their test server.

The solution to too many posts on a row is to edit the other posts, but perhaps you ran up against link limits.

3 Likes

Thanks @pfaffman, I didn’t want to mix up posts relating to different servers, so I keep the post about the un-upgraded live server seperate from the post about the upgraded development server as I thought it might get too confusing if I put everything into one post. I did try deleting previous posts but that only partially helped so I have now un-deleted all of them. The issue was one of too many posts in a row, I didn’t get any link limit warnings.

1 Like

I have a similar issue after upgrading from BETA6 to v2.2.0.beta8 +11, the favicon’s are not loading or loading and then being replaced with an empty page icon. It’s weird because if I have 3 windows open, one of them will have the favicon and the other two won’t. If I refresh the favicon loads for a split second and then is replaced by a empty page box icon.

It was working fine with BETA6.

Things I’ve tried

  1. Restart browser
  2. Incognito mode
  3. Remove all icons and replace them
  4. Use PNG for favicon
  5. Use ICO for favicon
  6. Reset to nothing (now it shows the discourse icon without an issue)
  7. Replace the favicon (same thing, one window shows the favicon the other shows a blank page box)
  8. Checked the security certificates (lets encrypt is enabled)
  9. Used the wizard and admin pages

Am a little lost here on what next to try. It’s just the favicon, the rest seems to be okay

There is a cache on the favicon, you will need to wait around 30minutes before it is properly updated.

2 Likes

The correct reaction to that should be

  • editing your earlier posts
  • waiting for someone to reply to you

not

  • creating a new account
1 Like

Waited for about 40 minutes, no change. What’s weird was when I testing it earlier, when I removed the Favicon, it defaulted back to the discourse favicon immediately and that when the page loads it shows the favicon for a split second and then it changes to an empty box.

image

Where next should I look/see/do?

EDIT: For what it’s worth I’m seeing another thing now with BETA8, in chrome now it’s giving a warning about loading unsafe scripts. Never has this issue before. I was reading somewhere on the release notes about something to do with cross site scripting. Wondering if that causing the isssues:

image

For new sites, CSP is on by default. Is this a new install?

Nope been there for almost 2 years, just recently updated from BETA6 to BETA8 and now these things have cropped up after the update.

You can check your site settings, CSP should be off by default then for an existing site that updated. It will be on by default when 2.3 is released though in summer 2019.

Can you check if there is a favicon configured in your site settings? If possible, please provide me with the URL.

You can see, just refreshed all the pages, once it shows the favicon, the next time it doesn’t.

2 Likes

When I posted a minute ago it looked like:

Now just by itself, notice the admin page favicon disappeared:
image