Upgrade to v1.4.0.beta4 - Can't create or modify tag


(flyabroad) #1

When upgrade to v1.4.0.beta4 my discourse forum can’t create or modify tags.

Tagging plugin is enabled, old tags still there, but can not create, assign or modify tags.

need help!


(Mittineague) #2

One recent change I’ve noticed is plugins now have “enabled”.

If you go to Admin -> Plugins does it show Tagging as enabled?


(flyabroad) #3

Thanks for your reply, The tagging plugin is enabled. I disable it and reable it dosen’t resolve it.


(Mittineague) #4

I just tried on my localhost 1.4.0 beta 4 and was able to create a new tag with no problem.

Is your Poll plugin also broken?

The only possible explanation I can think off is because of the missing translation. i.e. script is looking for a “Y” (or in your case the equivalent) and it’s not there so it’s acting as though it isn’t enabled


(Kane York) #5

Nope, basing logic off of translations is always a bad idea, and I didn’t add any of that here.


(flyabroad) #6

The Poll plugin is ok, maybe the default zh_CN locale cause this problem, In v1.2, users change UI language cause blank pages. This time I don’t know.

waiting for the 1.4 final.

Fallback localization to EN in production if missing string in locale.


(Discourse.PRO) #7

Yes, official Tags plugin is broken now
And official Solved plugin is broken too.
I think the core commits is not tested against the official plugins.
To fix the problem change update channel in app.yml from default tests-passed to beta or stable.


(Jeff Atwood) #8

Possibly, @eviltrout can have a look Tuesday. Or @sam can look Australia Monday.


(Mittineague) #9

I tested only last night and it worked for me.

I’m thinking it isn’t so much a problem with Core code but plugin conflicts.
* note, I do not have Akismet enabled on my localhost

There have been some “endless spinner” hangs and I see this in dev console

SyntaxError: unreachable code after return statement vendor.js:19437:6
Error: Could not find module `discourse/views/post-menu` imported from `discourse/plugins/discourse-solved/discourse/initializers/extend-for-solved-button` vendor.js line 11 > eval:111:0
syntax error report_js_error:1:1
Error: Assertion Failed: post-menu must be a subclass or an instance of Ember.View, not  vendor.js line 8 > eval:12062:0
syntax error report_js_error:1:1

(flyabroad) #10

When disable discourse-solved, tagging worked!

Uncaught Error: Could not find module discourse/views/post-menu imported from discourse/plugins/discourse-solved/discourse/initializers/extend-for-solved-button Url: http://bbs.fcgvisa.com/assets/
2 mins ago
x
Error: Could not find module discourse/views/post-menu imported from discourse/plugins/discourse-solved/discourse/initializers/extend-for-solved-button Url: http://bbs.fcgvisa.com/assets/vendor-68
a min ago
x
Could not find module discourse/views/post-menu imported from discourse/plugins/discourse-solved/discourse/initializers/extend-for-solved-button Url: http://bbs.fcgvisa.com/assets/vendor-68a043ffb
a min ago
x
Could not find module discourse/views/post-menu imported from discourse/plugins/discourse-solved/discourse/initializers/extend-for-solved-button Url: http://bbs.fcgvisa.com/assets/vendor-68a043ffb


Discourse Solved (Accepted answer plugin)
(Sam Saffron) #11

It is certainly broken here, will look at it australia tuesday.


(Mittineague) #12

Sorry for the red herring.

I’ve discovered that this was from one of my earlier plugin attempts.

I wanted a plugin-outlet that isn’t in the post.hbs file so it used a hacked copy of the template.

post.hbs has since changed - hence the “endless spinner” errors.


(Discourse.PRO) #13

Fixed 2 hours ago in test-passed branch: Backwards compatibility with deprecation for `Discourse.PostMenuView` · discourse/discourse@4706b77 · GitHub


(Jeff Atwood) #14