I made few additional fixes.
First of all, I found why one spec was failing for me in both master
and rails6
branch - https://github.com/discourse/discourse-calendar/pull/3
I also created pull requests for deprecated methods in various plugins:
- https://github.com/discourse/discourse-github/pull/8
- https://github.com/discourse/discourse-cakeday/pull/28
- https://github.com/discourse/discourse-translator/pull/23
- https://github.com/discourse/discourse-user-card-badges/pull/1
- https://github.com/discourse/discourse-yearly-review/pull/1 - this one was tricky and I am not 100% sure that this is correct
I rebased latest master
into rails6
branch
Finally, I updated rspec-rails
to version 4.0.0.beta2
and it works fine on my local machine. Travis got some problems, however I see same problems in other pull requests so I don’t think this is correlated to upgrade of rspec-rails
.