# Upgrading Ember to 2.10

**URL:** <https://meta.discourse.org/t/upgrading-ember-to-2-10/52724>\
**Category:** Development\
**Tags:** ember\
**Created:** [11월 9, 2016, 8:25오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724 "2016-11-09T20:25:24Z")\
**Posts on this page:** 12\
**Page:** 4

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [12월 19, 2016, 11:55오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/62 "2016-12-19T23:55:55Z")

</div>

Ember 2.10 is in at last!

![](https://global.discourse-cdn.com/meta/original/4X/8/e/3/8e31df6d83fd39026ab31984cada2e91f546c222.gif)

---

<div class="post-metadata">

**Author:** ![Lutz](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/lutz/32/65103_2.png) [@Lutz](https://meta.discourse.org/u/Lutz)\
**Post date:** [12월 20, 2016, 6:01오전 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/63 "2016-12-20T06:01:06Z")

</div>

This bug/issue is back after upgrading to Ember 2.10. With the revert it was gone.

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [12월 20, 2016, 6:04오전 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/64 "2016-12-20T06:04:20Z")

</div>

I can repro that (and the table misalignment bug) on my instances @eviltrout

---

<div class="post-metadata">

**Author:** ![carlokok](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/carlokok/32/115951_2.png) [@carlokok](https://meta.discourse.org/u/carlokok)\
**Post date:** [12월 20, 2016, 6:37오전 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/65 "2016-12-20T06:37:10Z")

</div>

This upgrade seems to have broken [GitHub - arpitjalan/discourse-topic-group-button: Adds a custom button at the bottom of a topic, visible only to staff or members of a specific group · GitHub](https://github.com/techAPJ/discourse-topic-group-button) again @techAPJ (Sorry)

---

<div class="post-metadata">

**Author:** ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)\
**Post date:** [12월 20, 2016, 4:12오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/66 "2016-12-20T16:12:41Z")

</div>

I’ve fixed the plugin for the new connector API but you’ll want to update your discourse to point [at this new repo](https://github.com/discourse/discourse-topic-group-button) location instead.

edit: replied to wrong person, was meant for @carlokok

---

<div class="post-metadata">

**Author:** ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)\
**Post date:** [12월 20, 2016, 4:15오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/67 "2016-12-20T16:15:08Z")

</div>

It seems raw templates in plugins are being registered with `javascripts/` in front of their name. This is what `Discourse.RAW_TEMPLATES` looks like when I run Topic List Previews.

 ![](https://global.discourse-cdn.com/meta/original/3X/5/6/56e4252161a1c9acf42a07d0e091585f234d19b1.png)

This means that existing templates are not being overridden. And that new plugin templates cannot be (easily) used.

It is possible to reopen the relevant class and update the `buildBuffer` method, e.g.

```plaintext
      buildBuffer(buffer) {
        const template = findRawTemplate('javascripts/list/topic-list-item');
        if (template) {
          buffer.push(template(this));
        }
      },

```

This works, but is not ideal. In terms of referencing my own raw templates, I tried just including `javascripts/` e.g.

`{{raw "javascripts/list/topic-thumbnail"}}`

However this was parsed as:

![](https://global.discourse-cdn.com/meta/original/3X/4/c/4cf0a10468d235aa7bd721f927b4114e3c10adf1.png)

---

<div class="post-metadata">

**Author:** ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)\
**Post date:** [12월 20, 2016, 4:50오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/68 "2016-12-20T16:50:34Z")

</div>

I’ve fixed the `docker_manager` issue:

[https://github.com/discourse/discourse/commit/16b236899c11977f73fbe851ae04d863179a9565](https://github.com/discourse/discourse/commit/16b236899c11977f73fbe851ae04d863179a9565)

---

<div class="post-metadata">

**Author:** ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)\
**Post date:** [12월 20, 2016, 4:54오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/69 "2016-12-20T16:54:37Z")

</div>

> [@angus](#):
>
> It seems raw templates in plugins are being registered with javascripts/ in front of their name

This commit should help with that:

[https://github.com/discourse/discourse/commit/da4e27ca7dd8e0706566c0165db8211217a7bde6](https://github.com/discourse/discourse/commit/da4e27ca7dd8e0706566c0165db8211217a7bde6)

---

<div class="post-metadata">

**Author:** ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)\
**Post date:** [12월 20, 2016, 5:54오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/70 "2016-12-20T17:54:37Z")

</div>

Thanks! I’ve got TLP [working again](https://meta.discourse.org/t/topic-list-previews/41630/497) with this. This fix works well for template helpers, i.e. I can now just use `{{raw "list/topic-thumbnail"}}`, however, I still need to override `buildBuffer` to use `javascripts/list/topic-list-item` instead of `list/topic-list-item` (see [here](https://github.com/angusmcleod/discourse-topic-previews/commit/45156b3c0ee5c7e604cee8eadbaa05be3ecd7b7f#diff-c69869dbf7142b5e0e049054ff4844b7R149)). Easy enough to do. Will this be the standard going forward, or a temporary measure?

---

<div class="post-metadata">

**Author:** ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)\
**Post date:** [12월 20, 2016, 6:07오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/71 "2016-12-20T18:07:46Z")

</div>

Aha, in that case perhaps we just prioritize `javascripts/` for raw templates:

[https://github.com/discourse/discourse/commit/1be800b673dc9b42e6ae0767971a6c2d8e096df7](https://github.com/discourse/discourse/commit/1be800b673dc9b42e6ae0767971a6c2d8e096df7)

I think with that it should work without overriding it.

---

<div class="post-metadata">

**Author:** ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)\
**Post date:** [12월 20, 2016, 6:14오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/72 "2016-12-20T18:14:42Z")

</div>

Yup, that did it 🙂 Thanks.

---

<div class="post-metadata">

**Author:** ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)\
**Post date:** [12월 22, 2016, 11:20오후 UTC](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724/75 "2016-12-22T23:20:04Z")

</div>

I should have thought of it at the time, but the raw mobile templates added from plugins need the same treatment. I’ve made a PR to that effect.

[https://github.com/discourse/discourse/pull/4620](https://github.com/discourse/discourse/pull/4620)

[이전 페이지](https://meta.discourse.org/t/upgrading-ember-to-2-10/52724.md?page=3)