'Uploading.. 0%' message is always shown in preferences page


(Yeonho Yoon) #1

‘Uploading… 0%’ message is always shown in preferences page like below.
the display: none from .hidden class gets overrided by display: inline in .btn.
It’s being reproduced in meta as of now.


(Jeff Atwood) #2

Another one for you @zogstrip?


(Erick Guan) #3

https://github.com/discourse/discourse/pull/2573


(Régis Hanol) #4

(Régis Hanol) #5

(Régis Hanol) #6

@fantasticfears Had to revert that change. It broke the modals.


(Sam Saffron) #7

General rule lets not !important our way out of bugs, it’s a slippery slope


(Erick Guan) #8

Yes, !important looks terrible. But when we use hidden, we usually mean it. It’s probably not a good idea to think about specificity everytime when you try to hide something. IMO, it should be a promise to hide anything if we added it.

For bootstrap, it use ‘display: none !important’.
For YUI, it use the same, but for hidden attr.

BTW, deploying master for meta is a great idea.


(Sam Saffron) #9

My point here is that our CSS should be structured in such a way that this is a non issue cc @awesomerobot


(Sam Saffron) #10

Looks like its fixed now, closing.


(Sam Saffron) #11