### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [3월 22, 2019, 11:43오전 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/8 "2019-03-22T11:43:08Z")
Entirely plausible, I suggest running basic disk perf stats, if your disks are slow (non-SSD) and you have a lot of activity and a large database.. it isn’t going to be pretty.
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 11:59오전 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/9 "2019-03-22T11:59:41Z")
We both know that the disk performance is insufficient. That is beyond my control.
I guess I’ll up the digest queue to 4 hours. I don’t see an alternative.
---
### Author:  [@neil](https://meta.discourse.org/u/neil)
#### Post date: [3월 22, 2019, 1:28오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/10 "2019-03-22T13:28:20Z")
> [@pfaffman](#):
>
> Have the process that **sends** the digest do another check of `last_emailed_at` before sending the digest (I think this might be the best long-term solution, but haven’t found that code)
I think this is a good solution too. Summary emails (and many others) are put into the low-priority queue, so are most likely to be delayed when sidekiq has a lot of jobs to process. I don’t think it’s too much of a hack to check last\_emailed\_at if it’s a digest email in [here](https://github.com/discourse/discourse/blob/master/app/jobs/regular/user_email.rb#L18-L24).
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 2:28오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/11 "2019-03-22T14:28:40Z")
Thanks, @neil. So something like
```
return if type.to_s == "digest" && user.last_emailed_at < user.digest_after_minutes
```
right about
>
?
---
### Author:  [@neil](https://meta.discourse.org/u/neil)
#### Post date: [3월 22, 2019, 2:44오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/12 "2019-03-22T14:44:55Z")
Yup, that’s about right.
```ruby
return if type.to_s == "digest" &&
user.last_emailed_at < user.user_option.digest_after_minutes.minutes.ago
```
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 2:47오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/13 "2019-03-22T14:47:48Z")
Aha! `.ago`. Obvious once I see it.
Should I submit a PR for this two-liner or will it be faster for you to just do it?
---
### Author:  [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [3월 22, 2019, 2:53오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/14 "2019-03-22T14:53:11Z")
> [@pfaffman](#):
>
> Should I submit a PR
That’d be awesome if you could also include a test 😉
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 2:57오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/15 "2019-03-22T14:57:47Z")
> [@zogstrip](#):
>
> That’d be awesome if you could also include a test
Offer to give a guy an inch. . . 😉
A test, huh? Having never written one, I think it’ll take me a couple hours to pull that off. It’s not too soon for me to learn how to do that, though. Maybe next week.
---
### Author:  [@neil](https://meta.discourse.org/u/neil)
#### Post date: [3월 22, 2019, 3:11오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/16 "2019-03-22T15:11:35Z")
I can do it and then you can be my accomplice if something breaks. 😛
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 3:17오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/18 "2019-03-22T15:17:19Z")
I think I"m a few minutes away from figuring out how to write the test. . . but then I’ll still have to figure out how to run it.
But I’d be honored to be your accomplice.
And if you’re going to write the test, then I’ll go back to writing bash tab completion for `./launcher`. It’s been bugging me for years.
---
### Author:  [@neil](https://meta.discourse.org/u/neil)
#### Post date: [3월 22, 2019, 3:19오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/19 "2019-03-22T15:19:26Z")
Turns out there’s a similar test to the one I wanted to write that has a problem… It isn’t actually testing anything, so I should fix that too.
```ruby
it "doesn't call the mailer when the user is missing" do
Jobs::UserEmail.new.execute(type: :digest, user_id: 1234)
expect(ActionMailer::Base.deliveries).to eq([])
end
```
^ Passes for valid user\_id values too.
---
### Author:  [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [3월 22, 2019, 3:24오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/20 "2019-03-22T15:24:21Z")
> [@neil](#):
>
> Turns out there’s a similar test to the one I wanted to write that has a problem… It isn’t actually testing anything, so I should fix that too.
This is getting way above my pay grade. 🙂
---
### Author:  [@neil](https://meta.discourse.org/u/neil)
#### Post date: [3월 22, 2019, 4:35오후 UTC](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291/21 "2019-03-22T16:35:58Z")
Fix is here:
[https://github.com/discourse/discourse/commit/399e937a38f4b4917e0c44897c308d39d4a844e1](https://github.com/discourse/discourse/commit/399e937a38f4b4917e0c44897c308d39d4a844e1)
[다음 페이지](https://meta.discourse.org/t/users-receive-multiple-summary-emails-when-sidekiq-queue-is-30-minutes/112291.md?page=2)