# Version check is incorrectly comparing stable and beta versions

**URL:** https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034
**Category:** Bug
**Created:** [June 26, 2020, 11:17am UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034 "2020-06-26T11:17:21Z")
**Posts on this page:** 6
**Page:** 1

<div class="post-metadata">

### Author: ![cjk77](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cjk77/32/151779_2.png) [@cjk77](https://meta.discourse.org/u/cjk77)
#### Post date: [June 26, 2020, 11:17am UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/1 "2020-06-26T11:17:21Z")

</div>

We’ve just updated to Discourse 2.5 (stable version), and this component (as well as the new [Topic Thumbnails](https://meta.discourse.org/t/topic-list-thumbnails-theme-component/150602) one) is still disabled:

 ![disabled](https://global.discourse-cdn.com/meta/original/3X/c/b/cbb7f316baaaa8cd7bd8f3561f3b56220ba07ad8.png)

Help!

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [June 26, 2020, 3:01pm UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/2 "2020-06-26T15:01:03Z")

</div>

Hi Chris - thanks for this. Looks like we have a bug in our version check code. 2.5.0 should be considered greater than 2.5.0.beta2, but right now it’s not. That’s what is causing the theme to be auto-disabled.

I just opened a PR with a fix:

[https://github.com/discourse/discourse/pull/10135](https://github.com/discourse/discourse/pull/10135)

I’m going to split this into its own topic, and will let you know once the fix is live in the stable branch.

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [June 30, 2020, 8:38am UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/3 "2020-06-30T08:38:34Z")

</div>

That’s now merged, so the theme version check should work correctly now. @cjk77 head to `/admin/upgrade` to update (you won’t receive a new version notification straight away)

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [June 30, 2020, 9:18am UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/4 "2020-06-30T09:18:42Z")

</div>

@cjk77 I have updated your forum and that message has disappeared now.

@david thanks!

---

<div class="post-metadata">

### Author: ![cjk77](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cjk77/32/151779_2.png) [@cjk77](https://meta.discourse.org/u/cjk77)
#### Post date: [June 30, 2020, 12:01pm UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/5 "2020-06-30T12:01:21Z")

</div>

Confirmed to be working as intended! Thank you both @david and @RGJ!!!

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [June 30, 2020, 6:51pm UTC](https://meta.discourse.org/t/version-check-is-incorrectly-comparing-stable-and-beta-versions/156034/6 "2020-06-30T18:51:41Z")

</div>