Vimeo embed URLs parsed incorrectly in email

The proposed fix FIX: vimeo iframe url when data-original-href is missing by ghassanmas · Pull Request #18894 · discourse/discourse · GitHub , you can also try it at https://discuss.gsgapp.io where I cherry-picked my commit.

I have perosnally tested for 4 cases:

  • pasting vimeo url of public video
  • pasting vimeo url of unlisted video
  • pasting iframe vanila of of public video
  • pasting iframe vanila of unlisted video

In all cases it lead to the email generating the correct url.

But anyway please try to test for all other possible variation that you might encournter and most importantly that it doesn’t break other thing.

The way I tested the e-mail template is that I would send myself a direct message, and then check the email inbox. (Since I have two accounts regitered at https://discuss.gsgapp.io)

2 Likes