Warning for github forks

(Caue Rego) #1

Continuing the discussion from Is anyone working on a Discourse Wiki?:

This should be, somehow (at least on the README.md), made into a warning for whoever tries to fork it, shouldn’t it? :slight_smile:

(cpradio) #2

Not really. It isn’t news that forked projects tend to stale out far faster than the original project. This comes down to upkeep and maintenance. If you fork, and you use your fork for the installation, now you must merge discourse/discourse with your fork to stay up to date, you simply added more work to your deployment process.

Sometimes there are good reasons to do this, for example, if you have heavily customized your Discourse instance and you want to ensure changes upstream do not break you. You now have 100% control over when and how you pull in the changes from upstream.

Forking and using a fork doesn’t need a warning because those doing it should be thinking these things already.

(Caue Rego) #3

Should / could move this into “support”! :wink:

Thanks, I was aware of this, but haven’t internalized it yet. Totally agreed.

We need a GitHub Discourse!

Then we could, maybe, figure out a way to improve the forking and pull requesting workflow. I still feel there are way too many people forking and dropping, and it could be improved with a simple JIT warning, but there are probably many better ways to go about this.

(cpradio) #4

Keep in mind, a lot of us forked it, so we could contribute back to it. To my knowledge, that is the only way you can submit a PR, you have to fork it commit your change to a branch on your fork, and then submit a PR to the Discourse repo.

I can’t think of very many installations that are running off a fork. I personally only know of 1.