My first run at this PR was pretty messy, I admit. I’ve since closed the initial PR, squashed commits and resubmitted . Is there a typical timeline for plugin PR review? Did I flub in not first asking for the functionality? It seemed like it ought to be pretty simple to do, so I thought I’d just “g…

I’ve reopened this one as though this particular PR has been merged the general question of what to do to nudge a PR is still a little open. From my viewpoint, I don’t keep track of PRs on GitHub (:grimacing:) so I think if we’re looking for a more formal answer to ‘what can I do to chase up a PR r…

[이미지] G Ann Campbell: Is there a typical timeline for plugin PR review? No, not really! Though it’s helpful if you post on Meta about it (I’ll take a look within the next day or two in this case).

We’ve got one waiting for review too: [이미지] Putting a button into Chat for Jitsi calls Feature We’ve got a PR for this at the moment: https://github.com/discourse/discourse-jitsi/pull/22 I wasn’t sure how to get someone’s attention on it without @mention…

[이미지] Nathan Kershaw: We’ve got one waiting for review too: I’ll pull someone’s sleeve for you :slight_smile:

I’ve just merged this. :tada: Thanks!

테마-컴포넌트 PR 리뷰를 받는 절차는 무엇인가요?

개발

nathank (Nathan Kershaw) 2월 27, 2024, 3:13오전 6

We’ve got one waiting for review too:

I wasn’t sure how to get someone’s attention on it without @mentioning / pestering

글		댓글	조회수
What is the turn around time for pull request? Development rest-api	2	302	8월 24, 2023
Requesting new features for Discourse Contributing how-to	0	10106	9월 7, 2015
When PRs are merged? Development	2	455	7월 8, 2022
How should participants manage third-party plugin reports on Meta Site feedback	3	169	4월 25, 2025
Recommended approach for production discourse using PR (not merged) Support	15	302	2월 21, 2025

테마-컴포넌트 PR 리뷰를 받는 절차는 무엇인가요?

Related topics