When clicking on @mention letter avatar flashes


(Sam Saffron) #1

When you click on an @mention the letter avatar flashes (this does not happen when you click on a user)

cc @eviltrout <-- click there to see E


(Kris) #2

Wait, why did I get notified for this post?


(Robin Ward) #3

Ah yes, the avatar code was trying to show the best avatar it could without an uploaded_avatar_id. I changed the code to not try and do that until the user information had loaded.

Unfortunately when all we have is the username to go off we can’t prepopulate as much in that popup.

https://github.com/discourse/discourse/commit/5aa411b58c25aae2e8b49f49a3c5c3731fb03969


(Robin Ward) #4

(Jeff Atwood) #5

Please make sure we are fixing the size of the avatar image tag width and height in the user card so it does not shift.


(Robin Ward) #6

Good call.

https://github.com/discourse/discourse/commit/f2b554be1361039a8cd7052232cb78de93a0e6ff