Hey Discourse Team, This marks the 1-year-and-1-month anniversary of the Rails 5 release, it looks like 5.1.3 will be out soon (second release candidate lands today). Wondering if there have been any thoughts on upgrading Discourse to Rails 5.x anytime soon? Why or why not?

Rails 5 broke a few of my plugins because of the change from before_filter to before_action. I did a quick search through GitHub - discourse/all-the-plugins · GitHub for before_filter and found these other ones that will be broken: ./plugins/babble/app/controllers/posts_controller.rb:4: before_fi…

@jafeth.diazc @joebuhlig @gdpelican see above post (could only mention 10 people at a time)

[image] david: discourse-slackdoor Not obsolete yet, I don’t think. This functionality doesn’t exist yet in the new slack plugin, does it? Will put it on my list to fix… Hopefully soon…

[image] mcwumbly: This functionality doesn’t exist yet in the new slack plugin, does it? Nope, not included in slack-official or chat-integration

Thanks for calling this out David. I hadn’t noticed Rails 5 was official yet so hadn’t touched this at all. Now it looks I need to hustle. :grimacing:

Nescis quid serus vesper vehat :first_quarter_moon_with_face: Thanks David. Note that, if you have written specs, all xhr :method, :action, params has to be re-written as method :action, params: params, format: :json

Thanks for the heads up @david , I’ve :wrench: my things. :smiley:

Is it safe to do an update of my forum at the moment? Are people finding any instability / upgrade issues post-Rails-upgrade?

Hang fire for now. @tgxworld is investigating a possible instability.

When should Discourse upgrade to Rails 5?

Development

mcwumbly (Dave McClure) September 26, 2017, 1:24am 33

Hopefully this is all that’s needed:

https://github.com/mcwumbly/discourse-slackdoor/commit/26ec8b4bf84aca08596d85c5f2fc8c8f1efa5d12

(Wish I had CI set up for this thing).

Topic		Replies	Views
Preparing for Discourse's upgrade to Ember 5 Announcements	53	7876	April 8, 2024
Upgrading Discourse to Rails 6 Development dev-news	17	4030	January 7, 2020
Fail to upgrade discourse Support	4	1977	December 3, 2016
Discourse Version 1.3 Announcements release-notes	1	20900	May 25, 2015
Discourse 2.5.0.beta3 Release Notes Announcements release-notes	1	4653	April 22, 2020

When should Discourse upgrade to Rails 5?

Related topics