Hey Discourse Team, This marks the 1-year-and-1-month anniversary of the Rails 5 release, it looks like 5.1.3 will be out soon (second release candidate lands today). Wondering if there have been any thoughts on upgrading Discourse to Rails 5.x anytime soon? Why or why not?

Hopefully this is all that’s needed: https://github.com/mcwumbly/discourse-slackdoor/commit/26ec8b4bf84aca08596d85c5f2fc8c8f1efa5d12 (Wish I had CI set up for this thing).

Nescis quid serus vesper vehat :first_quarter_moon_with_face: Thanks David. Note that, if you have written specs, all xhr :method, :action, params has to be re-written as method :action, params: params, format: :json

Thanks for the heads up @david , I’ve :wrench: my things. :smiley:

Is it safe to do an update of my forum at the moment? Are people finding any instability / upgrade issues post-Rails-upgrade?

Hang fire for now. @tgxworld is investigating a possible instability.

Looks like @tgxworld has concluded his investigation. Should be safe to update, but it couldn’t hurt to wait a day or two more while we finish ironing out any additional unexpected issues.

And if you use any non official plugins you’ll want to be especially careful.

I’m with @pfaffman here. I just finished pushing updates to the majority of my plugins to cover this but I’m sure there are others still working on it.

Thank you for your efforts! Does this mean that the username search related PR can finally be merged in? :slight_smile: https://github.com/discourse/discourse/pull/4974

@tgxworld I think the rails 5 upgrade may have introduced an issue with error handling in the application controller. I think I’ve tracked it down to any call to rescue_discourse_actions which has include_ember: true. I use this in my category-lockdown plugin (hence why I noticed), but it is also u…

When should Discourse upgrade to Rails 5?

مطور

rriemann (Robert) 27 سبتمبر 2017، 4:14م 41

Thank you for your efforts! Does this mean that the username search related PR can finally be merged in?

https://github.com/discourse/discourse/pull/4974

الموضوع		الردود	مرات العرض
Preparing for Discourse's upgrade to Ember 5 Announcements	53	7876	8 أبريل 2024
Upgrading Discourse to Rails 6 Development dev-news	17	4030	7 يناير 2020
Fail to upgrade discourse Support	4	1977	3 ديسمبر 2016
Discourse Version 1.3 Announcements release-notes	1	20900	25 مايو 2015
Discourse 2.5.0.beta3 Release Notes Announcements release-notes	1	4653	22 أبريل 2020

When should Discourse upgrade to Rails 5?

الموضوعات ذات الصلة