# 更新到最新提交时

**URL:** https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109
**Category:** Bug
**Created:** [2016年七月11日 17:13 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109 "2016-07-11T17:13:59Z")
**Posts on this page:** 10
**Page:** 1

<div class="post-metadata">

### Author: ![Alankrit\_Choudh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/alankrit_choudh/32/119698_2.png) [@Alankrit\_Choudh](https://meta.discourse.org/u/Alankrit_Choudh)
#### Post date: [2016年七月11日 17:13 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/1 "2016-07-11T17:13:59Z")

</div>

discourse (5a77f55)

 ![2pnmPZr](https://global.discourse-cdn.com/meta/original/4X/7/4/8/7488a80b263f4f265c2dbcf23516db0946faf65e.png)

在 Discourse 中通过 /admin/upgrade 收到了这个警告。

我需要担心吗？

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [2016年七月11日 17:27 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/2 "2016-07-11T17:27:25Z")

</div>

Weird, I haven’t seen this before. Is it working otherwise?

---

<div class="post-metadata">

### Author: ![Alankrit\_Choudh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/alankrit_choudh/32/119698_2.png) [@Alankrit\_Choudh](https://meta.discourse.org/u/Alankrit_Choudh)
#### Post date: [2016年七月11日 17:28 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/3 "2016-07-11T17:28:56Z")

</div>

yes it is working well and good. But the strike through on the docker upgrade got me worried.

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [2016年七月11日 17:30 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/4 "2016-07-11T17:30:19Z")

</div>

Probably not anything to be concerned about. I just did an update and didn’t see the same thing - I wonder if something random in the console screwed up the markup somehow. I’ll leave this open for a short while to see if anyone else can reproduce / confirm it.

---

<div class="post-metadata">

### Author: ![JSey](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jsey/32/3540_2.png) [@JSey](https://meta.discourse.org/u/JSey)
#### Post date: [2016年七月11日 17:54 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/5 "2016-07-11T17:54:32Z")

</div>

Yeah, started here:

 ![](https://global.discourse-cdn.com/meta/original/3X/4/b/4b025cde50726bf27da45b63029390ba3a5b2d52.png)

(Paging captain obvious… 😉 )

---

<div class="post-metadata">

### Author: ![gauthier](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gauthier/32/59292_2.png) [@gauthier](https://meta.discourse.org/u/gauthier)
#### Post date: [2016年七月11日 18:20 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/6 "2016-07-11T18:20:04Z")

</div>

Hello,

Same here:

 ![](https://global.discourse-cdn.com/meta/original/3X/e/b/eb7495842c5fb5361216efd4488e95394b91dbb9.jpg)

---

<div class="post-metadata">

### Author: ![Freso](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/freso/32/49081_2.png) [@Freso](https://meta.discourse.org/u/Freso)
#### Post date: [2016年七月11日 18:22 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/7 "2016-07-11T18:22:24Z")

</div>

Heh. I came here to report the same thing. Looks like HTML isn’t properly escaped. I doubt anyone will be able to get an exploit into the commit messages (and if they are, we likely have bigger things to worry about), but it might still be nice to fix this. 🙂

---

<div class="post-metadata">

### Author: ![JSey](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jsey/32/3540_2.png) [@JSey](https://meta.discourse.org/u/JSey)
#### Post date: [2016年七月11日 18:22 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/8 "2016-07-11T18:22:32Z")

</div>

I think the problem is clear now: the commit text mentioned that `<strike>` wasn’t whitelisted, so after the ~~, all the messages got stricken… 😉~~

Question is, is there a clever way to prevent such behaviour in the future? Especially if we’re dealing with a commit that fixes `</html>`? The alternative being: wait for the next commit which will fix this problem. 😃

@Freso was a tad faster. 🙂

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [2016年七月11日 20:42 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/10 "2016-07-11T20:42:57Z")

</div>

Thanks for the help everyone! Here’s a fix to the escaping issue:

[https://github.com/discourse/docker\_manager/commit/82c061a5bc4a793dfd919e7271a2c6660b41f917](https://github.com/discourse/docker_manager/commit/82c061a5bc4a793dfd919e7271a2c6660b41f917)

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [2016年七月11日 20:43 UTC](https://meta.discourse.org/t/while-updating-to-the-latest-commit/47109/11 "2016-07-11T20:43:07Z")

</div>