Similar to some bugs before, if you look at the post count given in the linking box of a post, it gives the post #. However, this doesn’t match the numbers displayed in the navigation bar on the right. I think this topic may demonstrate the problem: Migrate a phpBB3 forum to Discourse - #580 by gerhard [image] So the last post on the topic (at the time of writing) is being called “post #580”, but but the scroll bar shows 256 / 257. Looking at the second post in the topic, it is numbered #303, so I’m guessing there are some whispers before it. Also there is a gap in the numbers after this post: Migrate a phpBB3 forum to Discourse - #307 by Canapin Maybe a whisper there again?

[image] TallTrees: critical/paranoid members who somehow imagine something terrible going on right, but this is not a software problem with Discourse, just reassure your users that it’s normal and carry on. There is 0.0% chance we will be changing this behavior.

[image] riking: aren’t willing to compromise on the position of displaying posts in order (such as how large platforms like Twitter are handling the deleted posts issue). Would you be willing to expand or link to reference on what twitter is doing? I’m not a tweeter, so have no reference to compare/contrast what discourse is doing here.

Here’s the pithy version :blush: check that date https://twitter.com/dril/status/760997832237129729 By constantly shuffling the order that replies are shown, deleted or unwanted replies can be conveniently buried with no easy way for you to prove this is happening. Additionally, incendiary responses can be boosted to the top, algorithmically stoking the flame wars instead of cooling them.

Ahh… the curated order thing. I hadn’t thought of the effect that this would have on records of deleted posts, etc.

[image] riking: I’m of the opinion that it’s a combination of necessary transparency and not-going-to-be-noticed. Yep - I totally agree with that. That’s why I think it would be better if the two ‘post numbers’ shown on the same screen agree (screen shot is in my post above), even if the post number in the URL (which usually needs scrolling) would still give away the actual post sequence number. Given the scroller on the page knows the ‘visible’ number of each post, I’m not sure why this would be hard to re-use on the post dialog, but then I’ve not looked at the code either!

[image] TallTrees: Given the scroller on the page knows the ‘visible’ number of each post, I’m not sure why this would be hard to re-use on the post dialog, but then I’ve not looked at the code either! I also don’t know how the code handle it, but my guess is that the total count can be done fast with an aggregate database select that counts the non-deleted and non-whispered posts using a postgres index. On the other hand, showing each post actual number (ignoring whispers and deleted posts) could cause a huge penalty in the performance to have a near zero benefit. It could also be made with a background process that updates the numeration of the posts whenever a new post is created or deleted (and having a wrong numeration in the meantime). Both options don’t sound good to me, although I’m guessing more or less how the total count is calculated (if the post ids are retrieved first and the total amount is calculated later, it might be more likely that what you asked can be achieved with less penalties). (Here I’m just considering changing the display number, not the url, because changing the url would be even worse, with links pointing to wrong posts as time passes) I think about this “problem” in the numeration as a trade-off: it’s not the ideal scenario, but among the other possibilities, I consider the way it’s doing now as the best one. Furthermore, which practical scenario would be the ideal one? (that’s why I say it’s a trade-off)

[image] lucasbasquerotto: It could also be made with a background process that updates the numeration of the posts whenever a new post is created or deleted (and having a wrong numeration in the meantime). Another thing that would have to be done in the background would be to change the URLs where links have been referenced in other topics. Here’s where there could also be problems: Shared links to other sites. If the URLs were changed to match the time slider, they won’t match the URLs that had been previously shared.

[image] lucasbasquerotto: On the other hand, showing each post actual number (ignoring whispers and deleted posts) could cause a huge penalty in the performance to have a near zero benefit. I think that’s unlikely. As you scroll down a page, the actual visible post number is already shown in the scroll / navigation bar on the right. The request is simply to use this number in the popup box when looking to link a post. Link box: [image] Scroll bar: [image] On this topic they match (because there are presumably no deleted posts or whispers). Yay :slight_smile:

I can’t test with this topic because the numbers are correct, but if the current number in the timeline is correct and can be associated with the post, then that would require only a small change at the front-end. So, yeah, that could be achieved without penalties (as long as only the post number changes, not the url).

Yep - exactly that. The timeline does it right, so reusing that data \ logic would for the post # (but not in the URL) is all that’s needed.

So what you are saying is that if anyone ever links externally to post #17 and we take them to post #78 cause a bunch of posts got deleted - no problems - better design? What is the point of half changing this?

Whispered replies leak in the post number

Product Support

riking (Kane York) January 25, 2021, 11:34pm 30

But then you’re just going to get people asking why this is happening.

Topic		Replies	Views
Post URLs different from Post numbers Product Support	6	662	August 15, 2020
Toggle Whisper :eye: Theme component whispers	41	4436	June 25, 2025
Unfortunately I had to pull the plug Community Building	98	13030	December 24, 2022
Post number on slider disagrees with post Product Support	10	1144	July 20, 2019
Questions about moving an existing forum to Discourse Community Building	21	3399	December 26, 2018

Whispered replies leak in the post number

Related topics