Youtube is Z-fighting again


(Kane York) #1

Discourse Meta
Youtube video overlapping with header and composer
Discourse Meta

They’re at it again.

I’ve also noticed this at gifsound.com


(Sam Saffron) #2

@awesomerobot can you have a look at some point?


(Vikhyat Korrapati) #3

Adding &wmode=opaque to the iframe src here would fix this: onebox/whitelisted_generic_onebox.rb at master · discourse/onebox · GitHub


(Sam Saffron) #4

cool, can you add a PR for that ?


(Kris) #5

hmm, that might explain why I can’t reproduce it - &wmode=opaque effects the flash player, but I don’t think the HTML5 player has the issue


(Vikhyat Korrapati) #6

This should fix it:

https://github.com/dysania/onebox/pull/194

I ended up adding a separate Onebox for Youtube like there was before since it turns out the method I linked above isn’t actually, rather the HTML returned was coming directly from StandardEmbed and it would’ve been pretty ugly to add it there.


(Jeff Atwood) #7

Just another regression, we fixed this in the original oneboxer but it was lost in the new one. Easy fix though.


(Sam Saffron) #8