Youtube video overlapping with header and composer


(Vikhyat Korrapati) #1

Continuing the discussion from Youtube embeds cover compose panel:

Is this the pull request you are referring to? Fixed Youtube videos appearing on top of compose panel by hrobertson · Pull Request #1566 · discourse/discourse · GitHub

It looks like it was closed without merging in, and I just tried creating a Onebox for a Youtube video using the latest Discourse – and the wmode=opaque parameter is not set on the iframe.

[1] pry(main)> Oneboxer.onebox_nocache("http://www.youtube.com/watch?v=iEBJGDps60Q")
=> ["<iframe width=\"480\" height=\"270\" src=\"//www.youtube.com/embed/iEBJGDps60Q?feature=oembed\" frameborder=\"0\" allowfullscreen></iframe>",
 "<img src='//i1.ytimg.com/vi/iEBJGDps60Q/hqdefault.jpg'>"]

Youtube is Z-fighting again
(Régis Hanol) #2

I merged this PR manually today

https://github.com/discourse/discourse/commit/8d47215ea5c79cd1fc8edf3f6bd2513db4c53f5b


(Régis Hanol) #3