Digest Logo not working

Contribute Bug

AI-generated summary

A user, davidkingham, reported an issue with their digest logo not working after switching to uploaded logos instead of linked ones. codinghorror and tgxworld investigated the issue, with tgxworld asking davidkingham to run a command to retrieve the SiteSetting.site_digest_logo_url. The investigation revealed a bug in the code, which tgxworld confirmed and fixed in a GitHub commit (https://github.com/discourse/discourse/commit/27c793a192ea0443373dc65517b50dfa21480441). Tests were also added to cover this previously untested part of the code.

1

Since the change to having logos as uploads rather than links, my digest logo has stopped working. Yes, I have uploaded a new logo:

image
image1193×357 14.7 KB

But this is the digest:

image
image2019×798 59.1 KB

This is the URL for the image:

https://ci4.googleusercontent.com/proxy/pj0QhGINR6LmV6slyHT0mQ6rcILIxXC3kekgB-DeNGTNDXh4FCQtm8hk-nysl0JhuBoGEZUAiiljA6eS7icAp4LOG6galFaDjJ1BqOnTbOzHqxHCRjN_Vg2dbu8RTWL1buTBra7SFGqQJD_-lper0LAgCrPk--1rc4v9vjOHbsrorT_uCqxGADYz0Rv2JXqBaY00nCwFRLibiDEdea21jd7YVigHEJXpAYFSmXvbe2dk7Kgbyu-BOKQ0oQAR=s0-d-e1-ft#https://community.naturephotographers.network//nature-photographers-network.s3.dualstack.us-west-1.amazonaws.com/original/1X/392476f143ac7f4a55f1ecd60612fea96e0f1f37.png

3 Likes
Images on AWS missing from body of emails on iOS Mail app
2

Hmm we should check this @tgxworld

2 Likes
4

@davidkingham What does the following give you?

./launcher enter
rails c
SiteSetting.site_digest_logo_url(warn: false)
SiteSetting.digest_logo

The url seems weird https://community.naturephotographers.network//nature-photographers-network.s3.dualstack.us-west-1.amazonaws.com/original/1X/392476f143ac7f4a55f1ecd60612fea96e0f1f37.png

3 Likes
5 
=> #<Upload:0x000055e389528790
 id: 776,
 user_id: 1,
 original_filename: "392476f143ac7f4a55f1ecd60612fea96e0f1f37.png",
 filesize: 6712,
 width: 800,
 height: 136,
 url:
  "//nature-photographers-network.s3.dualstack.us-west-1.amazonaws.com/original/1X/392476f143ac7f4a55f1ecd60612fea96e0f1f37.png",
 created_at: Mon, 10 Sep 2018 14:58:37 UTC +00:00,
 updated_at: Mon, 10 Sep 2018 14:58:37 UTC +00:00,
 sha1: "392476f143ac7f4a55f1ecd60612fea96e0f1f37",
 origin: nil,
 retain_hours: nil,
 extension: "png",
 thumbnail_width: 690,
 thumbnail_height: 117>
6

Thanks for reporting @davidkingham. I’ve confirmed that this was indeed a bug and fixed it in

https://github.com/discourse/discourse/commit/27c793a192ea0443373dc65517b50dfa21480441

This part of the code was also untested territory so I’ve added tests as well.

6 Likes
7

This topic was automatically closed after 2 days. New replies are no longer allowed.