Is there any way to disable service worker initializer ? Because my web served at example.com with it’s own registered service worker, I embed discourse forum which under the same domain example.com/forum for SSO. Discourse forum would unregister all my parent page service worker.

I don’t think we have a “disable service worker” switch, you may be able to swing something in a theme component, it makes sense to have a switch or at least a white list of service worker js files that we never de-register for the sub folder case.

Thanks for your reply. In my opinion, it would be better to register and unregister service worker under the base-url scope, not the whole domain.

Correction, we only de-register stuff that we know is ours: app/assets/javascripts/discourse/initializers/register-service-worker.js.es6 2863abefd if ( registration.active && !registration.active.scriptURL.includes( Discourse.ServiceWorkerURL ) ) { registration.unregister(); } One spinner is that we de-register apple cause it is buggy at the moment: app/assets/javascripts/discourse/initializers/register-service-worker.js.es6 2863abefd const isApple = !!navigator.platform.match(/(Mac|iPhone|iPod|iPad)/i); As to using scope here, I think it makes sense to make the change to Discourse provided scope is well supported.

if ( registration.active && !registration.active.scriptURL.includes( Discourse.ServiceWorkerURL ) ) { registration.unregister(); } shouldn’t this if condition to be this one to only unregister Discourse ServiceWorker ? if ( registration.active && registration.active.scriptURL.includes( Discourse.ServiceWorkerURL ) ) { registration.unregister(); }

Yeah reading through this we are being mega aggressive with de-registrations due to historic moves of our url. @tgxworld any thoughts here? should we be more accurate here.

Could you provide some workaround now ? I saw some tutorials about plugins? Can I write a plugin to overwrite the initialize/js file ?

We need to fix the file so we only de-register our stuff, maybe look for a specific string. @tgxworld can you add this to your list, should be an easy change.

Looks like registration didn’t consider subfolder support as well. Fixed in https://github.com/discourse/discourse/commit/abbc639e0d362ae90b52c8b5c6922d9e610777f8 @Jacky_Cheng Let me know if this fixes it for you :slight_smile:

Thanks for your reply. I forgot to bring up that Safari now can support service-worker. So const isApple = !!navigator.platform.match(/(Mac|iPhone|iPod|iPad)/i); should be remove Mac condition in my opinion. Also in discourse/app/assets/javascripts/discourse/initializers/register-service-worker.js.es6 at abbc639e0d362ae90b52c8b5c6922d9e610777f8 · discourse/discourse · GitHub the else condition would also unregister service worker, it should add the url condition.

[image] Jacky_Cheng: I forgot to bring up that Safari now can support service-worker. Yup we know but Discourse is not ready to support Service workers on Safari yet because it has been problematic for us so far. [image] Jacky_Cheng: the else condition would also unregister service worker, it should add the url condition. It does consider the URL condition because I extracted both of the unregister function calls into a common function.

Disable service worker initializer

Development

robbiet480 (Robbie Trencheny) June 22, 2019, 5:32am 14

Just a FYI that I’ve submitted a PR to once again enable the service worker on Apple platforms so that push notifications start working as per my findings here.

Topic		Replies	Views
Discourse Development: Failed to register/update a ServiceWorker Product Support	6	1339	June 11, 2018
Exploring ServiceWorkers for Discourse Feature	24	9753	February 22, 2018
Android+Chrome not registering service workers Bug	6	3205	April 9, 2018
Adding service workers for third party services Development	0	625	October 16, 2018
Discourse as a Progressive Web App Feature	21	5459	January 30, 2017

Disable service worker initializer

Related topics